Repository navigation
Give structured record details full width and release 0.18.11 - #72
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Records with structured arrays and companion Markdown previously squeezed all account decisions into the narrow narrative sidebar. At a 1280px desktop viewport, labels could wrap one character per line even though the underlying data rendered correctly.
Move Record details to a full-width grid row when it contains a nonempty model object array. Put each rich array's label above its value, preserving scalar formatting, narrative content, attachments, workflow actions and typed relationship links. Coordinate both packages and scaffolder fallback metadata for patch 0.18.11; model and approval semantics stay unchanged.
Validation: two independent combined code/security passes clean; 90 focused rendering tests; full documented validation; both package packs; zero-vulnerability audit; fresh packed consumer with 224 resources, zero errors and zero warnings. Own local browser used a generic three-account review with companion Markdown, 1280px desktop and 390px mobile, confirming wide readable rows and links, no horizontal overflow and no console/page/network failures. Inspected current screenshots at
/tmp/filegrc-structured-detail-width.pngand/tmp/filegrc-structured-detail-width-mobile.png. A separate real 86-row consumer browser check confirmed the desktop layout before release. Own fixture server stopped.Released as v0.18.11 at
1fc9f58b72a811f16324f2aa0a2713dd187d76da; merged tree matches reviewed headf2c0e70469344d8cb0a4588066556581d45763fc. All five required PR checks, main validation, and trusted npm publication/installed README smoke passed. Both packages report latest 0.18.11 with provenance attestations.