Repository navigation
test: stabilize direct blob request metric assertion - #91
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make the direct blob request acceptance test wait for the asynchronous
BlobsSentmetric update after the response frame is observed.Why
The receiver can process the frame before the sender goroutine resumes after
writePeerFrameand records the successful-send metric. The post-merge CI job exposed this timing-sensitive assertion in run34106626297.How
Use the existing
require.Eventuallypolling pattern with a short bounded timeout. Production send accounting is unchanged.Testing
go test -run '^TestRun_blobGetOverRealTCP$' .git diff --check