Repository navigation
Take the plugin's name off a graphics library that already had it - #6
Merged
Merged
Conversation
The plugin directory rejected "Lienzo." as a name, and it was right to. Lienzo is a live HTML5 Canvas graphics toolkit -- kiegroup/lienzo-core, the one behind jBPM Designer and the Drools decision tables -- so a canvas-based image editor called Lienzo is not a coincidence a reviewer has to talk themselves into. It is also just the Spanish for "canvas", which is the second half of the same objection: the one defence available, that nobody can own a common noun, is an argument that the name describes the thing rather than distinguishing it. So: AllTerrain Photo Editor for OpenStation, slug and text domain `allterrain-photo-editor`. The distinguishing term leads, the dependency is named in the "for X" position that reads as unaffiliated, and neither half is anybody else's. What did NOT change is everything a user cannot see. `lienzo_*` prefixes, `LIENZO_*` constants, the `lienzo/v1` namespace, the script handles and window ids, and above all `_lienzo_recipe` and `_lienzo_source` stay exactly as they are. Those two meta keys already carry a `_daguerre_*` fallback from the last rename; a second one would mean every saved edit re-opening with its sliders back at zero, to settle a question about a word on a page. The review asked for the display name, the slug and the text domain, and that is what moved. Two other things the same review raised. `store.php` was requiring `wp-admin/includes/media.php` and never calling anything from it -- the two requires left name the function each is for. And the readme credited a contributor who is not the account that owns the submission. The directory art is redrawn, because the banner said "Lienzo." in ninety-point type and the icon was an L. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019yKS7zgubsgpYd3e2Rh5U6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WordPress.org review rejected "Lienzo." as a plugin name. It was right to: Lienzo is a live HTML5 Canvas graphics toolkit (
kiegroup/lienzo-core, behind jBPM Designer and the Drools decision tables), so a canvas-based image editor of the same name is a collision rather than a coincidence. It is also just the Spanish for "canvas" — which is the second half of the objection, since the only available defence (nobody owns a common noun) concedes that the name describes the thing instead of distinguishing it.New name: AllTerrain Photo Editor for OpenStation — slug and text domain
allterrain-photo-editor. Distinguishing term first, dependency named in the "for X" position that reads as unaffiliated.What moved
Plugin name and header,
lienzo.php→allterrain-photo-editor.php, text domain (59 PHP strings plus the JS domain ini18n.ts), the admin page slug, Plugin URI, readme, every user-facing string,.wp-env.json,package.json,composer.json,phpcs.xml.dist,bin/*.mjs, and both workflows —release.ymlstill carriedSLUG: lienzoandBUILD_DIR: ./dist/lienzo, which would have published to the wrong SVN path.What deliberately did not
lienzo_*prefixes,LIENZO_*constants,lienzo/v1, script handles and window ids, and above all_lienzo_recipe/_lienzo_source. Those two already carry a_daguerre_*fallback from the last rename; a second one would mean every saved edit re-opening with its sliders at zero, to settle a question about a word on a page.Also from the same review
store.phprequiredwp-admin/includes/media.phpand never called anything from it. Removed; the two remaining requires name the function each is for.Verification
Plugin Check passes clean. 120 PHPUnit, 414 vitest,
tscandphpcsall green.dist/allterrain-photo-editor.zipunpacks to the correct slug folder.🤖 Generated with Claude Code
https://claude.ai/code/session_019yKS7zgubsgpYd3e2Rh5U6