Repository navigation
Label the control, not the box it came in — and keep the inspector on its side - #21
Merged
Merged
Conversation
… its side Selecting fields printed DevTools' two label complaints on repeat, and both traced to row(): it minted an id for whatever element it was handed, so a composite control — the formula input with its editor button, a group of tick boxes — got a label pointed at a <div> whose inner input had no id at all. The id now lands on the first real control inside the wrapper, and a row holding no control at all gets a heading span instead of a label, because a label bound to nothing is the complaint. And the narrow window's rail swap moves to where the memory said it was: the inspector stays on its own right side — canvas left, editor right, exactly the full-width arrangement minus the palette — instead of teleporting to the left edge, which read as a different UI rather than the same one with one rail folded away. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0119U4sRRWGcTQdwYreTwpAp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two field-selection complaints from testing: DevTools' 'form field element should have an id or name' + 'incorrect use of label[for]' (row() labelled wrapper divs — now the id lands on the first real control inside, or the row gets a heading span when there is none; audited 8 field types → 0 bad targets, 0 console flags), and the narrow-window rail swap now keeps the inspector on the right — canvas left, editor right, same arrangement as full width minus the palette. 607 PHPUnit ✓ 261 vitest ✓.
🤖 Generated with Claude Code
https://claude.ai/code/session_0119U4sRRWGcTQdwYreTwpAp