Repository navigation
The Save bar stops hiding, and every control wears the shell - #26
Merged
AllTerrainDeveloper merged 1 commit intoAug 21, 2026
Merged
Conversation
`inset-block-end: 0`, exactly: the sticky action bar carried a -14px offset meant to cancel the host's bottom padding, which parked half the bar past the scrollport edge where the window body's overflow clipped it. The host gives up its bottom padding instead — the bar owns the bottom edge now, at zero, fully visible at every size. And the last three native controls in the validation UI become the shell's own: the answer-shape picker is an <os-select> (group headings ride along as disabled options, painted muted and unpickable — the reading an optgroup heading gives), the editor's two modes are an <os-segmented>, and the character-group tick boxes go through the checkbox() helper's <os-checkbox-label>. The native select with real optgroups stays as the plain-admin-page fallback. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0119U4sRRWGcTQdwYreTwpAp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two review findings on the custom-rule child window (follow-up to #25):
The half-cut Save bar
The sticky action bar carried
inset-block-end: -14px— meant to cancel the host's bottom padding, but a negative sticky offset parks part of the bar past the scrollport edge, where the window body'soverflow: hiddenclips it. Hence the half-cut buttons at some window sizes. Fixed properly: the host gives up its bottom padding, the bar owns the bottom edge atinset-block-end: 0, fully visible at every size and scroll position.os-* everywhere
The last native controls in the validation UI now use the shell's components:
<os-select>. It has no optgroup concept, so the group headings (Contact, Numbers & codes, Text shape, Web, Your own) ride along as disabled<os-option>rows — the listbox paints them muted and unpickable, the same reading an optgroup heading gives.<os-segmented>.checkbox()helper's<os-checkbox-label>, which also sidesteps the wp-admin raw-checkbox styling traps that helper documents.The native select with real optgroups (and plain buttons/checkboxes) remains as the fallback on the plain admin page, where the components don't exist.
QA'd live on 8889: bar fully visible and pinned, segmented switch works, grouped listbox renders, picks write through, cancel-on-X still reverts the picker.
🤖 Generated with Claude Code
https://claude.ai/code/session_0119U4sRRWGcTQdwYreTwpAp