-
Notifications
You must be signed in to change notification settings - Fork 0
Update site webmanifest with PWA icons and binary-extensions #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
d3a9712
72cc4d4
3e46730
53c80a8
b550514
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "name": "", | ||
| "short_name": "", | ||
|
Comment on lines
+2
to
+3
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Empty PWA name fields will result in poor installation experience. The 🤖 Prompt for AI Agents |
||
| "icons": [ | ||
| { "src": "/android-chrome-192x192.png", "sizes": "192x192", "type": "image/png" }, | ||
| { "src": "/android-chrome-512x512.png", "sizes": "512x512", "type": "image/png" } | ||
| ], | ||
| "theme_color": "#ffffff", | ||
| "background_color": "#ffffff", | ||
| "display": "standalone" | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Dependency Conflict with Binary-Extensions
Added "binary-extensions": "3.1.0" as a direct dependency creates a version conflict. The code in apps/sim/app/api/files/parse/route.ts imports and uses binary-extensions expecting it to be an array (line 369: binaryExtensionsList.includes(extension)). However, transitive dependency is-binary-path@2.1.0 requires binary-extensions@^2.0.0, creating a situation where both v3.1.0 and v2.3.0 could be present in node_modules. This major version bump may have breaking changes and the lock file (bun.lock line 4016) shows both versions being pinned, indicating a dependency conflict that wasn't present before this change.