Skip to content

Create site.webmanifest with icons and colors; add binary-extensions#24

Draft
vdimarco wants to merge 3 commits into
mainfrom
terragon/add-site-webmanifest-2g40ir
Draft

Create site.webmanifest with icons and colors; add binary-extensions#24
vdimarco wants to merge 3 commits into
mainfrom
terragon/add-site-webmanifest-2g40ir

Conversation

@vdimarco

@vdimarco vdimarco commented Oct 28, 2025

Copy link
Copy Markdown

Summary

  • Adds a site.webmanifest (PWA manifest) for the docs site
  • Adds new icon assets (Android Chrome, Apple touch, favicons)
  • Updates manifest to reference new icons and remove placeholder/maskable entries
  • Sets manifest name and short_name to empty strings; preserves theme_color (#ffffff)
  • Adds binary-extensions to docs sim tooling; updates lockfile
  • Includes small tooling and test adjustments to align imports/formatting

Changes

Public assets

  • Added new icon files:
    • apps/docs/public/android-chrome-192x192.png
    • apps/docs/public/android-chrome-512x512.png
    • apps/docs/public/apple-touch-icon.png
    • apps/docs/public/favicon-16x16.png
    • apps/docs/public/favicon-32x32.png
  • Updated apps/docs/public/favicon/site.webmanifest to:
    • Use actual icon paths: "/android-chrome-192x192.png" (192x192) and "/android-chrome-512x512.png" (512x512)
    • Remove maskable-specific entries
    • Set name and short_name to empty strings
    • Preserve theme_color (#ffffff)

Manifest

  • Ensures the manifest references the correct icons and is free of maskable entries
  • Keeps the theme_color as white to align with existing UI

Dependency updates

  • Added "binary-extensions" to apps/sim/package.json
  • bun.lock updated to reflect binary-extensions v3.1.0

Tooling/Code changes

  • Minor formatting/import adjustments for consistency:
    • apps/sim/providers/gatewayz/index.ts: slight formatting and line-break adjustments
    • apps/sim/providers/utils.ts: adjusted import ordering
  • Root tooling adjustments:
    • package.json and related configs updated to use bun x style commands (bunx -> bun x)
    • bun.lock updated to include binary-extensions entry changes

Tests

  • Updated tests in apps/sim/executor/index.test.ts to align with formatting/concurrent test adjustments (still using skip for the concurrent test)
  • apps/sim/package.json updated to include binary-extensions

Test plan

  • Serve and verify the manifest at /favicon/site.webmanifest is reachable
  • Inspect the manifest to confirm icons section lists 192x192 and 512x512 with correct paths
  • Check that theme_color is #ffffff and name/short_name are empty
  • Ensure new public icon assets are present in the repository and load correctly in the docs site
  • Verify that binary-extensions is installed in the docs sim environment (lockfile reflects it)

🌿 Generated by Terry


ℹ️ Tag @terragon-labs to ask questions and address PR feedback

📎 Task: https://www.terragonlabs.com/task/e6075a3c-c0be-44c8-b3b2-8435b8d99d4a

- Added new favicon images for multiple resolutions
- Updated existing favicon images with new versions
- Modified site.webmanifest to reference updated favicon files and cleared name fields

Co-authored-by: terragon-labs[bot] <terragon-labs[bot]@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Oct 28, 2025

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch terragon/add-site-webmanifest-2g40ir

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Added binary-extensions version 3.1.0 to package.json and bun.lock to update project dependencies.

Co-authored-by: terragon-labs[bot] <terragon-labs[bot]@users.noreply.github.com>
@vdimarco vdimarco changed the title Create site.webmanifest with icons and colors Create site.webmanifest with icons and colors; add binary-extensions Oct 28, 2025
…ation

Reformatted the skipped concurrent test to improve readability and maintain code style consistency in the executor test suite. No functional changes were made.

Co-authored-by: terragon-labs[bot] <terragon-labs[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant