Scale strip transverse width by full direction in get_strip_region_2d#175
Merged
Conversation
`get_strip_region_2d` was treating transverse width as if it were based on the primitive direction, which made strips too narrow for non-primitive directions like `(2, 2)`. This updates the transverse bound to use the full rotated direction scale, aligns the docstring with the actual geometry, and adds regression coverage for scaled diagonal strip cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #173
Summary
This PR fixes
get_strip_region_2dso transverse strip width is scaled by the full input direction instead of the primitive direction.Previously, non-primitive directions such as
(2, 2)produced strips that were too narrow because the transverse bound was effectively computed in primitive-normal spacing. This change makes the transverse constraint use the rotated full direction and updates the documentation to match that geometry.Changes
(-dy, dx)instead of the primitive directiondx^2 + dy^2get_strip_region_2ddocstring to describe the actual strip coordinates and shell spacinglhsandrhs0.4.1to0.4.2Why
width_stepshould reflect the strip induced by the supplieddirection, not a collapsed primitive version of it. Without this fix, downstream geometry code can receive incomplete strip regions for scaled directions.Testing
tests/test_geometry_ops.pycoverage for scaled diagonal directions(2, 2)and related diagonal examples