fix(research): enforce provenance digest and knowledge-time integrity - #48
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A repository audit found that the canonical research domain was weaker than the public provenance/no-hindsight contract:
ResearchDocumentduplicated provenance fields, did not validatetext_sha256, and several research records relied on application-layer checks forknown_at <= recorded_atrather than enforcing the invariant in the domain object itself.What
source_artifact_id/import_batch_iddeclarations and duplicate validation fromResearchDocument;known_at <= recorded_at(or the persisted creation timestamp for links) across documents, claims, evidence, thesis revisions, contradictions and links;Deliberate boundary
This PR does not impose
effective_at <= known_atglobally. Existing Clausula temporal contracts consistently useknown_at <= recorded_at, while effective-time semantics can require separate bitemporal review. That question should be decided explicitly rather than tightened incidentally during this repair.Release sequencing
This is integrity remediation on the already implemented research layer. It does not activate the deferred AI workflow roadmap or merge #41.