fix(web): default the mirror to wrap on - #59
Merged
Merged
Conversation
Panes herdr spawns get the desktop terminal's column width (190 in the issue reporter's session), but a phone in portrait shows roughly 45-50 columns. With wrap off by default, the mirror pans horizontally for most lines even though it is showing agent prose, not TUI tables, most of the time. Flip the default to wrap: true so the common case reads without panning; column-faithful no-wrap for TUI tables stays one tap away in View. Bump the display-prefs storage key from v3 to v4 so devices that already persisted wrap: false pick up the new default instead of being stuck on the old one. This is part 1 of #53 only. Part 2 (reading source: "recent-unwrapped" so wrap re-flows logical lines instead of re-wrapping desktop-width fragments) is out of scope here and keeps the issue open. Refs #53 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Flipping the default left the no-wrap rendering reachable only through the View toggle and asserted by nothing — the shape a later refactor drops without a single test noticing. Pin both: wrap breaks at the viewport, no-wrap stays column-faithful and pans. Refs #53 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #53 (part 1 of two — the issue stays open).
DEFAULTS.wrap: false → true, plus aSTORAGE_KEYbump v3→v4 so devices that already persistedwrap: falseadopt the new default instead of being stuck on the old one.The old default's rationale ("preserves column alignment like desktop Herdr") is right for TUI tables
and wrong for what the mirror actually shows most of the time. Herdr spawns panes at the desktop
terminal's width — 190 columns in the reporter's session — against a phone's ~45–50, so panning was
the common case, not the exception. Column-faithful no-wrap stays one tap away in View.
What this does NOT fix: with the bridge still reading
source: "recent", the browser re-wrapslines already hard-broken at 190 columns, so breaks land mid-sentence. That is #53's second half
(
recent-unwrapped), which has to be threaded from a client pref through the read and risks theClaude grammars that key off visible layout — its own change, on its own evidence.
Also pins both wrap branches. The no-wrap rendering is now reachable only through the View
toggle and was asserted by nothing; a negative control confirms the new default test fails if the
default is reverted.
web: 92 files / 1226 tests green. Typecheck clean.