chore(release): v0.12.1 by sahrizvi · Pull Request #1338 · AltimateAI/altimate-code

sahrizvi · 2026-09-21T11:46:52Z

Issue for this PR

Closes #

Release PR for v0.12.1. It closes no single issue; the review findings that were deferred are tracked as #1337 (routing ignores the IDE pin, assigned to Sarav) and #1335 (workspace name in the system prompt).

Type of change

Bug fix
New feature
Documentation

What does this PR do?

Both features the release ships are already on main: #1330 (identity every turn) and #1320 (IDE pin). This PR carries what the release process produced on top of them:

Review fixes (c7a8348d25), from a five-persona review of v0.12.0..main that looked specifically at the seam between the two PRs (they changed resolveBindingOutcome from opposite sides and were never reviewed together):
- a pin served from the offline grace window is marked stale, so identity says "last known" for it; pinValidation is bounded;
- identity's memo is keyed on the credential digest as well as tenant/host (the pin cache already was);
- under a pin, identity's deadline fallback never reaches for the project's own cached link;
- a pinned session is described as pinned, with the caveat that warehouse routing still follows the project's link (workspace: tool routing (precedence/engine-probes) ignores the IDE extension's pin, so a pinned session can name one workspace and route to another #1337); the unknown copy no longer promises that retrying helps;
- the persistent shell tool strips the same host markers as bash (stripHostMarkers, shared), so a nested serve cannot inherit a pin;
- pin.ts states the extension contract (a pin is fixed for the process's life); docs for the three pin variables, ALTIMATE_CODE_SERVE, and the identity line.
Adversarial-test fixes (a1852b5574): readPin accepted 1e3/0x10 via Number() — decimal digits only now; MAX_SECTION_CHARS was below the pinned-and-stale identity copy with a maximum-length name, so render dropped the name — raised, with a test over every shape.
release: v0.12.1 (09c092738d): the CHANGELOG entry and test/skill/release-v0.12.1-adversarial.test.ts.

The one P0-candidate from the review — tool routing never consults the pin — was verified in code and downgraded with the release owner: routing behaviour is identical to v0.12.0 (the pin never affected it), the failure is a prompt inconsistency rather than execution against a workspace the project was not already linked to, and the fix belongs in precedence.ts/engine-probes.ts with its own tests (#1337). Identity's pinned copy states the limitation in the meantime.

main's ruleset requires a PR for any push. Once this merges, the release owner tags v0.12.1 on the new main tip.

How did you verify your code works?

bun test over test/altimate/workspace, test/altimate/plugin, test/session/prompt.test.ts, test/upstream/bridge-merge.test.ts, test/cli/run/run-mode.test.ts, test/tool/{shell,bash}.test.ts and the new adversarial file: 850 pass / 0 fail before the adversarial commit; the five pin/identity files plus the adversarial file: 104 pass after it. Every new guard was deleted once to confirm its test fails (grace-path stale, credential-scoped key, pin-aware fallback, the id parser, the cap).
tsgo --noEmit clean; upstream marker guard clean.
OPENCODE_VERSION=0.12.1 bun run pre-release: all four checks pass; the dist binary, run by path, reports 0.12.1.
script/release-preflight.ts --version 0.12.1 --stage tag: PASSED.
feat(workspace): state the linked workspace every turn, and mean the Altimate one #1330's copy was checked live against freemium before it merged (unlinked, linked, "current workspace", Databricks questions in both states).

Screenshots / recordings

N/A — system-prompt text and process-environment changes; no UI change.

Checklist

I have tested my changes locally
I have not included unrelated changes in this PR

🤖 Generated with Claude Code

https://claude.ai/code/session_012Q51zFUmPg1WwtS5CrGJE6

Summary by cubic

Release PR for v0.12.1, carrying the two workspace features already on main — the agent naming the Altimate Workspace the project is linked to every turn (#1330) and the IDE extension pinning the workspace for the serve process it launches (#1320) — plus the fixes their joint review and this release's adversarial tests found. The one P0 candidate, tool routing never consulting the pin, was verified as behavior identical to v0.12.0 and tracked separately (#1337).

Pin/identity seam

A pin served from the offline grace window is marked stale; identity's memo is keyed on the credential as well as tenant and host, and its deadline fallback never renders the project's own cached link under a pin.
Pinned sessions are described as pinned, with the caveat that warehouse tool routing still follows the project's link; the persistent shell tool strips the same host markers as bash via a shared stripHostMarkers, including every case spelling on Windows.
readPin accepts decimal ids only and a whitespace-only pin is invalid; the identity section cap fits every shape with a budget-sized name.
Identity renders unknown without invoking the resolver when no complete account is configured, so a hung or empty-credential session never stalls a turn.
The #937 env-plumbing guard now verifies ALTIMATE_AUTO_ANSWER survives the marker strip both behaviorally and by source.
The CHANGELOG now points the resolver-scope caveat at workspace: resolver caches are scoped by tenant+host, not credential — a same-tenant account switch can inherit the previous account's cached link for up to 5 min #1339, and the shell child-env test handles Windows' PATH/Path enumeration.

^{Written for commit a2ff011. Summary will update on new commits.}

Summary by CodeRabbit

New Features
- Added workspace identity reporting for IDE-selected and project-linked workspaces.
- Added IDE workspace pinning for sessions launched through supported extensions.
Bug Fixes
- Improved workspace validation, account isolation, caching, and offline handling.
- Clarified when workspace information reflects the last known verified state.
- Prevented workspace markers from leaking into child shell processes across platforms.
- Improved handling of invalid or unavailable workspace pins.
Documentation
- Updated CLI guidance for workspace routing, pinning behavior, environment settings, lifecycle, and limitations.

…identity seam Five-persona review of v0.12.0..main. #1320 (IDE pin) and #1330 (identity every turn) changed `resolveBindingOutcome` from opposite sides and were never reviewed together; every item here is on that seam. - A pin served from the offline grace window is marked `stale`, so the identity section says "last known" for it as it already did for a cached link. `pinValidation` is bounded like the other caches. - Identity's memo is keyed on the credential digest as well as the tenant and host — two accounts on one tenant no longer share an entry (the pin cache in `state.ts` already did this). - Under a pin, identity's deadline fallback never reaches for the project's own cached link — the workspace the pin exists to override. - A pinned session is described as pinned by the IDE extension, with the caveat that warehouse tool routing still follows the project's own link (#1337); the unknown copy no longer promises that retrying helps. - The persistent `shell` tool strips the same host markers as `bash` (`ALTIMATE_CODE_SERVE`, the pin trio, headless, non-interactive) via a shared `stripHostMarkers`, so a nested `serve` cannot inherit a pin. - `pin.ts` states the extension contract: a pin is fixed for the life of the process; a panel switch means relaunching `serve`. - Docs: the three pin variables and `ALTIMATE_CODE_SERVE` in cli.md, and a note on the identity line and the pin under "Workspaces (pilot)". Tests: pinned-session copy, pin-aware fallback, same-tenant credential switch, grace-path stale, host-marker stripping. Each guard was deleted once to confirm its test fails. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012Q51zFUmPg1WwtS5CrGJE6

…ry shape Two defects the v0.12.1 adversarial tests found. - `readPin` took any string `Number()` parses — "1e3", "0x10", "1.0" — as an id. The extension never writes those; only decimal digits (with surrounding whitespace) are a pin now, the rest fail closed as before. - `MAX_SECTION_CHARS` (1,000) was below the pinned-and-stale identity copy with a budget-sized label (1,238), so `render` failed closed and dropped the name — and for the plain stale shape (1,078) too. Raised to 1,500; a test renders every shape with the worst-case label and checks the name survives. Adds `test/skill/release-v0.12.1-adversarial.test.ts`: hostile pin environments, root traversal (including the documented symlink bypass), host-marker stripping by exact name, and the identity copy across pin × stale × unbound. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012Q51zFUmPg1WwtS5CrGJE6

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012Q51zFUmPg1WwtS5CrGJE6

claude

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

_{Tip: disable this comment in your organization's Code Review settings.}

github-actions · 2026-09-21T11:47:04Z

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

Open an issue describing the bug/feature (if one doesn't exist)
Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

coderabbitai · 2026-09-21T11:47:10Z

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

📝 Walkthrough

Walkthrough

The change updates IDE workspace pin validation and identity reporting, adds stale-binding handling and credential-scoped memoization, sanitizes child-process environments, and adds documentation, release notes, and adversarial test coverage.

Changes

Workspace pilot behavior

Layer / File(s)	Summary
Pin validation and identity resolution `packages/opencode/src/altimate/workspace/pin.ts`, `packages/opencode/src/altimate/workspace/state.ts`, `packages/opencode/src/altimate/workspace/identity.ts`	Workspace IDs use strict decimal parsing. Pin validation is bounded and can return stale bindings during the offline grace period. Identity memoization includes credential scope, and rendered text distinguishes IDE pins from project links.
Child-process marker cleanup `packages/opencode/src/tool/bash.ts`, `packages/opencode/src/tool/shell.ts`	The bash and shell tools use shared host-marker stripping before spawning child processes.
Validation, documentation, and release coverage `packages/opencode/test/altimate/workspace/*`, `packages/opencode/test/cli/run/run-mode.test.ts`, `packages/opencode/test/skill/release-v0.12.1-adversarial.test.ts`, `packages/opencode/test/release-validation/question-937-codex.test.ts`, `docs/docs/usage/cli.md`, `CHANGELOG.md`	Tests cover pin validation, stale bindings, credential isolation, root checks, marker stripping, and rendering. CLI documentation and release notes describe the workspace behavior and environment variables.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Other

Sequence Diagram(s)

sequenceDiagram
  participant IDEExtension
  participant ServeProcess
  participant WorkspaceState
  participant WorkspaceAPI
  participant IdentitySection
  IDEExtension->>ServeProcess: set workspace pin environment
  ServeProcess->>WorkspaceState: resolve pinned binding
  WorkspaceState->>WorkspaceAPI: validate workspace visibility
  WorkspaceAPI-->>WorkspaceState: validation result
  WorkspaceState->>IdentitySection: provide bound or stale outcome
  IdentitySection-->>ServeProcess: render workspace identity

Merge Risk: 🟡 Moderate · up to a2ff0

A same-tenant account switch can show a prior account’s cached workspace, while concurrent tests can intermittently use the wrong resolver. Resolve these issues before release unless the documented cache limitation is explicitly accepted.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 58.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 12 functions across 11 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies this as the release pull request for version 0.12.1.
Description check	✅ Passed	The description follows the required template and includes the change summary, verification steps, screenshots status, checklist, release context, and known deferred work.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Fix all pre-merge checks with AI

✨ Finishing Touches 💡 2

📝 Generate docstrings 💡

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

🛠️ Fix failing CI checks 💡

Commit to this branch
Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{A rabbit checks the workspace pin,
Keeps stale truths when storms begin.
Child markers hop out of sight,
Credentials keep each memo right.
Tests guard roots and names with care,
Release notes bloom in autumn air.}

_{Comment @coderabbitai help to get the list of available commands.}

kilo-code-bot · 2026-09-21T11:53:01Z