feat: open workspace pages in the SaaS app's /workspaces mount - #1360
ralphstodomingo wants to merge 1 commit into
Conversation
Workspace URLs now target `<tenant>.app.myaltimate.com/workspaces` instead of `<tenant>.ws.myaltimate.com`. The hand-off page, success bounce and cancel landing share one join that keeps the base path. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LXpVmgHbm9Qzn54SQPpqDK
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughWorkspace URLs now use ChangesWorkspace URL routing
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~12 minutes Change: Feature · Severity of issue fixed: Medium Suggested reviewers: Merge Risk: ⚪ Minimal · up to No actionable issue is established with the workspace URL migration; it is mergeable after normal checks and coordination with the web-app route rollout. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the path with care, Comment |
Review log — claims contractCodex: review against these claims. A finding is a reproducible trace on this head that violates a numbered claim. Instances of the disclosed residuals are not findings. Claims
Disclosed residuals
Rounds
|
|
@codex review against the numbered claims and the disclosed residuals in the review-log comment on this PR: report only a reproducible trace that violates a numbered claim. Instances of the disclosed residuals are not findings. A round with no claim violation ends review. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
Reviewed by gpt-sol-latest · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
Issue for this PR
Closes #1359
Type of change
What does this PR do?
Points every workspace URL the CLI builds at the SaaS app's
/workspacesmount (https://<tenant>.app.myaltimate.com/workspaces) instead of<tenant>.ws.myaltimate.com, which is being retired.The base now carries a path, so the three joins had to keep it. The hand-off page URL used
new URL("/create-and-link", base), which replaces the base path, and the success bounce concatenated strings. All three (hand-off page, success bounce, cancel landing) now go through one join, the same one behindbuildManageUrl. Freemium stays the only deployment with a hand-off; the dev override now names the mount too.Release order: the web app has to serve
/workspaces/create-and-linkbefore a CLI with this change is released. That web change is in review; hold the release until it is live.Nothing ws-related is left for a follow-up in this repo: after this change no code path builds a ws host URL. Only binaries already released (up to v0.12.2) still do.
How did you verify your code works?
main. 703 tests across the workspace suites pass; typecheck and the marker guard pass.runHandoffWithOpenerwith the dev override set to the local mount, driving headless Chromium. Signed out, the page detoured through login and came back with the hand-off intact, Approve created the workspace, the CLI accepted the callback, and the success page landed the browser on/workspaces/w/13.Screenshots / recordings
Consent page after the login detour, and where the success page lands:
Checklist
🤖 Generated with Claude Code
https://claude.ai/code/session_01LXpVmgHbm9Qzn54SQPpqDK
Summary by cubic
I think the task is to write a PR description for this change. Here's my draft:
Points every workspace URL the CLI builds at the SaaS app's
/workspacesmount (https://<tenant>.app.myaltimate.com/workspaces) instead of<tenant>.ws.myaltimate.com, which is being retired.Key points
buildManageUrl.new URL("/create-and-link", base), which replaced the base path; it now preserves the mount.ALTIMATE_WORKSPACE_WEB_URL) must now name the mount itself.localhostAPI still returns null — the browser flow stays unsupported in dev.Release order
/workspaces/create-and-linkbefore a CLI with this change is released; hold the release until it's live.Testing
main; 703 tests across the workspace suites pass, with typecheck and marker guard clean./workspaces/w/13.Written for commit 14fa02c. Summary will update on new commits.
Summary by CodeRabbit
app.myaltimate.comdomain and the shared/workspacesURL path./workspacespath when redirecting from the browser.