Repository navigation
feat: telemetry for the workspace link lifecycle, usage, engine and starter #1513
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,6 +12,8 @@ import { Config } from "@/config/config" | |
| import { Flag } from "@/flag/flag" | ||
| import { InstallationVersion } from "@opencode-ai/core/installation/version" | ||
| import { Log } from "@/altimate/util/log" | ||
| // altimate_change — reads the config telemetry opt-out without an Instance | ||
| import { TelemetryConfig } from "../telemetry/config-state" | ||
|
|
||
| /** | ||
| * Why a failure reason is attached at the rejection site rather than inferred from the message: | ||
|
|
@@ -75,7 +77,9 @@ const log = Log.create({ service: "altimate-plugin" }) | |
| // and `cli_version` are strings, treat `cli_version: "local"` as a valid dev | ||
| // build, and treat the payload as untrusted (anyone can craft a URL). An absent | ||
| // `machine_id` means "do not attribute" — it must never be aliased on. | ||
| /** `directory`: the project the command acts on, whose config may opt out; the process's working | ||
| * directory when the command has none (`auth login`). */ | ||
| export async function buildCliContext(machineIdPath?: string, directory?: string): Promise<string> { | ||
| // altimate_change start — honour both telemetry opt-out gates, mirroring | ||
| // telemetry/index.ts::doInit: | ||
| // 1. ALTIMATE_TELEMETRY_DISABLED / OPENCODE_DISABLE_TELEMETRY env vars | ||
|
|
@@ -90,17 +94,25 @@ export async function buildCliContext(machineIdPath?: string): Promise<string> { | |
| } catch (err) { | ||
| // Config was unreadable — NOT the normal path. Server routes run inside | ||
| // Instance.provide() (AsyncLocalStorage-propagated across awaits), so | ||
| // Config.get() resolves during an ordinary browser authorize(). It fires on | ||
| // the paths that skip instance bootstrap: `altimate auth login <url>` and the | ||
| // create-and-link hand-off of `altimate-code link`. Read `telemetry.disabled` | ||
| // from the config files directly: an opt-out there, or files that cannot be | ||
| // read (an opt-out may be behind them), omit the id. Only a config that | ||
| // readably leaves telemetry on defers to the telemetry module's own state | ||
| // (opted out by env, no sink, test runner). | ||
| const state = await TelemetryConfig.disabledState(directory) | ||
| if (state === "enabled") { | ||
| await Telemetry.init().catch(() => {}) | ||
| disabled = !Telemetry.isEnabled() | ||
|
Comment on lines
+104
to
+107
There was a problem hiding this comment.
 |
||
| } else { | ||
| disabled = true | ||
| } | ||
| log.info("cli_context: config unavailable, read the opt-out from the files", { | ||
| code: (err as NodeJS.ErrnoException)?.code, | ||
| state, | ||
| enabled: !disabled, | ||
| }) | ||
| } | ||
| } | ||
| let machineId = "" | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor — the contract says
generationgainsworkspace_id; this list (and the code) leave it outThe contract in AltimateAI/altimate-code-analytics#22 says this PR "also adds workspace_id to
generation,agent_outcome,plan_revision, ...". Every other row in that sentence hasworkspace_id?in its type and is stamped from the turn's binding (...turnWorkspacein session/prompt.ts);generation(type at telemetry/index.ts ~271, emitted in session/processor.ts ~1053) has neither. This list is right about the code, so the contract sentence is the stale side.Suggestion: either stamp the turn's workspace on the
generationrow (thread the turn binding into the processor's emit) or dropgenerationfrom the contract sentence. Either way, make the two agree.Non-blocking: the analytics funnel reads
generationonly bymachine_id, so no query or client depends on it; a contract edit or a small follow-up.