Repository navigation
fix(session): cancel stalled streams and preserve partial findings - #1527
Conversation
- add `abortableStream` so provider setup and each read race the abort signal, independent of provider cooperation - hard abort now commits partial text and task results before publishing idle - `task` tool recovers committed child findings (labelled incomplete) after cancellation - budget-finalization fallback notes keep the last unfinished assistant text Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: dfbd88f0-7f2e-48ef-bbb1-940ca53d1753) |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fd4b8eb720
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 13 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Code Review SummaryStatus: 5 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (13 files)
Fix these issues in Kilo Cloud Reviewed by gemini-4-argon · Input: 140K · Output: 6.1K · Cached: 1.1M Review guidance: REVIEW.md from base branch |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: ecf9fe27-0c7b-44c4-90ef-ee596d20e3ef) |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
5891314
into
feat/analyst-harness-dab-2026-10
1 participant
Issue for this PR
Closes #1484
Stacked on
feat/analyst-harness-dab-2026-10(#1441).Type of change
What does this PR do?
Why: a provider stream that stops delivering events (and ignores cancellation) kept a run hung past its time budget, and partial findings from interrupted work were lost.
Root cause:
LLM.stream()and the provider iterator were awaited directly, so abort was only observed after another event; hard abort published idle before partial output was committed;taskdiscarded child findings when the child prompt rejected/returned empty; failure notes replaced earlier unfinished text.Before -> after:
abortable-stream.ts, listeners removed, iterator cleanup requested without awaiting a stuckreturn()).task: "Tool execution aborted" -> committed child findings returned, labelled incomplete (task-output.ts); metadata publishes child session and prompt message IDs before dispatch.Partial assistant response (not finalized).Deferred: no new post-tool timeout (no evidence of the historical transport cause); soft-interrupt polling unchanged. Review follow-ups (P2, not fixed): recovery after compaction/continuation turns only sees the original prompt lineage; batched tasks publish metadata on the outer batch part so recovery does not apply to them; a finalization stall before the first step leaves unfinished text without the warning note.
How did you verify your code works?
bun run typecheckinpackages/opencode: pass.git diff --check: clean.v1.17.9baseline:processor.ts,task.ts,run.tsexist upstream; all altimate edits are inside balanced, non-nestedaltimate_changemarkers (one nested pair inprocessor.tsfixed).prompt52,registry14,project-scan86,db1,processor-effect59,abortable-stream4,task13,run-output10,budget-finalization+time-budget+compaction95, 0 fail).Screenshots / recordings
N/A
Checklist
🤖 Generated with Claude Code
Note
Medium Risk
Touches core session streaming, abort lifecycle, and task delegation—behavior changes on cancel and time-budget exits, though covered by new tests and scoped upstream_fix markers.
Overview
Fixes runs that could hang past time budgets when a provider stream stalled, and stops losing partial work on cancellation.
Provider cancellation:
LLM.stream()consumption now goes throughabortableStream, so abort/deadline wins races on stream open, pendingnext(), and triggers iterator cleanup without waiting on a stuckreturn().Abort commit ordering: On hard abort, partial text/reasoning and in-flight tools are finalized first (including
tasktools that recover child session text viainterruptedTaskOutput/messageIDin metadata);SessionStatusidle is deferred until after those commits. Soft generation interrupt still closes open parts without clearing finish when only the request was aborted.Task tool & adapters: Cancelled tasks return labelled partial child findings instead of a bare abort error; metadata is published (with child
messageID) before the child prompt runs, withthrowIfAbortedafter async metadata. Legacy/batch tool bridges now await asyncmetadata()instead of fire-and-forget.CLI
--output: When bounded finalization cannot produce an answer, the harness note can append Partial assistant response (not finalized) from the last non-final step text (OutputCollector.preserveLastText).Reviewed by Cursor Bugbot for commit be50cc0. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by cubic
Fixes runs hung past their time budget when provider streams stall or ignore cancellation, and preserves partial findings from interrupted work instead of discarding them.
LLM.stream()inabortableStreamso provider setup, reads, and iterator cleanup race the abort signal and cannot hang the session.Partial assistant response (not finalized)instead of emitting a note alone.No migration steps. Deferred: recovery after compaction only sees the original prompt lineage, batched tasks still publish metadata on the outer batch part, and a finalization stall before the first step leaves unfinished text without a warning note.
Written for commit be50cc0. Summary will update on new commits.