Repository navigation
chore: upgrade @altimateai/altimate-core to 0.8.0 - #1530
Conversation
- Pin `@altimateai/altimate-core` 0.8.0 and refresh `bun.lock` (main + 5 platform packages). - Exempt the first-party `@altimateai/altimate-core*` packages from the 3-day `minimumReleaseAge` in `bunfig.toml`, matching the existing first-party/pinned excludes, so a core release can be adopted on the day it ships. - Update the tests that pinned the old fail-closed behaviour: DuckDB `//`, `TIMESTAMPTZ '...'`, a `match` alias and SQLite `NOT GLOB` now parse and run as reads; enable the previously skipped `//` aggregate test; keep parse-failure coverage with a malformed `string_agg`. Closes #1529 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 911a771b-4cfb-48ff-8bca-eebb2648d365) |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly and concisely identifies the primary change: upgrading @altimateai/altimate-core to 0.8.0. |
| Description check | |
The description includes the issue reference, change type, detailed change summary, verification results, screenshot status, and completed checklist. It also documents the two unrelated test timeouts … |
| Linked Issues check | |
Issue #1529 requires the @altimateai/altimate-core pin update to 0.8.0 and test updates for syntax that previously failed closed. The PR updates packages/opencode/package.json, refreshes `bun.lock… |
| Out of Scope Changes check | |
The Bun release-age exclusions support installation of the six upgraded first-party packages on release day. The targeted SQL tests verify the issue behavior. The version-reference documentation match… |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2… |
Full details: Description check
-
Explanation
The description includes the issue reference, change type, detailed change summary, verification results, screenshot status, and completed checklist. It also documents the two unrelated test timeouts and their baseline behavior.
Full details: Linked Issues check
-
Explanation
Issue
#1529requires the@altimateai/altimate-corepin update to 0.8.0 and test updates for syntax that previously failed closed. The PR updatespackages/opencode/package.json, refreshesbun.lockfor the main and five platform packages, and updates classification and execution tests for DuckDB//,TIMESTAMPTZliterals, amatchalias, and SQLiteNOT GLOB. The tests retain parse-failure coverage for malformedstring_aggSQL. The dbt AST parsing andDBT006finding are supplied by the upgraded dependency, so no consumer implementation is required.
Full details: Out of Scope Changes check
-
Explanation
The Bun release-age exclusions support installation of the six upgraded first-party packages on release day. The targeted SQL tests verify the issue behavior. The version-reference documentation matches the dependency upgrade. The reviewed changes show no unrelated product, API, or UI work.
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit checks the parser’s trail,
Two slashes pass without fail.
Four read forms move along their way,
A malformed query marks its parse error today.
Core’s new version joins the stack,
And release-age waits step back.
Comment @coderabbitai help to get the list of available commands.
|
👋 This PR was automatically closed by our quality checks. Common reasons:
If you believe this was a mistake, please open an issue explaining your intended contribution and a maintainer will help you. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
|
👋 This PR was automatically closed by our quality checks. Common reasons:
If you believe this was a mistake, please open an issue explaining your intended contribution and a maintainer will help you. |
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 files)
Previous Review Summaries (2 snapshots, latest commit 7507c57)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 7507c57)Status: No Issues Found | Recommendation: Merge Files Reviewed (6 files)
Previous review (commit 5b3a5d5)Status: No Issues Found | Recommendation: Merge Files Reviewed (5 files)
Reviewed by gemini-4-argon · Input: 70.5K · Output: 672 · Cached: 95.7K Review guidance: REVIEW.md from base branch |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 3ba86801-f860-46a1-9e28-f3fd725743aa) |
|
👋 This PR was automatically closed by our quality checks. Common reasons:
If you believe this was a mistake, please open an issue explaining your intended contribution and a maintainer will help you. |
full receipts (5 sessions)
codex ·
|
|
👋 This PR was automatically closed by our quality checks. Common reasons:
If you believe this was a mistake, please open an issue explaining your intended contribution and a maintainer will help you. |
1 similar comment
|
👋 This PR was automatically closed by our quality checks. Common reasons:
If you believe this was a mistake, please open an issue explaining your intended contribution and a maintainer will help you. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: cdc405f3-1c25-4fe5-813e-fa2abffba8cb) |
1 participant
Issue for this PR
Closes #1529
Type of change
What does this PR do?
This PR upgrades
@altimateai/altimate-corefrom 0.7.0 to 0.8.0. That version is published to npm with all five platform packages, and to PyPI.What users get from 0.8.0
sql_executeused to treat these statements as writes and ask for approval; they now classify and run as plain reads://integer divisionTIMESTAMPTZ '…'literalsmatchNOT GLOBDBT006finding for hardcoded relations. Findings flow through generically, so no consumer code changes were needed.Changes in this PR
packages/opencode/package.json: the pin is now 0.8.0.bun.lockis refreshed, with the main package and its five platform packages at 0.8.0 and no other changes.bunfig.toml: adds the six@altimateai/altimate-core*package names tominimumReleaseAgeExcludes. These are exact names, not a wildcard. Without the exemption, the 3-day cooldown blocksbun installfrom resolving a core release on the day it ships. The list already exempts other first-party and pinned packages such as@opentui/*and@ff-labs/*. Exact version pins and integrity hashes still apply.sql-execute.test.ts: the four statements now assert no approval request and exactly one dispatch of the original SQL.sql-classify.test.ts://aggregate test is enabled and expectsread.string_aggkeeps parse-failure → write coverage.SELECT (tests are unchanged. They cover the write-approval path with the parse diagnostic in its metadata, both when the write is denied and when it is approved.How did you verify your code works?
All runs were local against the installed 0.8.0 (
require('@altimateai/altimate-core/package.json').version→0.8.0).bun run typecheckinpackages/opencode: clean.bun test test/altimate: 9194 pass, 2 fail. The two failures aredatamate_manager list-integrations5-second timeouts. They fail the same way onmainwith 0.7.0 in this local environment and passed in CI on feat(analyst): harness robustness for data-question runs #1441. They are unrelated to this change.bun test test/skill test/cli/check-e2e.test.ts test/install/smoke-test-binary.test.ts, the other suites that use core: 1158 pass, 0 fail.b12bce3775..5b3a5d5e30: no P0, P1 or P2 findings.0.7.0pin reference indocs/internal/deterministic-checks-engine-split.md, fixed in7507c57efe. It also tried adding writes after the newly parseable syntax, and all of them were still classified as writes.Screenshots / recordings
Not applicable. There are no UI changes.
Checklist
🤖 Generated with Claude Code
Summary by CodeRabbit
Bug Fixes
TIMESTAMPTZ, andMATCHsyntax, as well as SQLiteNOT GLOBqueries. These queries are recognized as reads and can proceed without write approval.string_aggqueries now report a parse error while remaining unblocked as writes.Updates
Note
Medium Risk
Bumps the native SQL engine and changes read/write classification for queries that previously required write approval, which affects the safety gate around
sql_execute.Overview
Upgrades
@altimateai/altimate-corefrom 0.7.0 to 0.8.0 (lockfile andpackages/opencodepin), and documents the new pin in internal engine-split docs.bunfig.tomlnow exempts the six@altimateai/altimate-core*package names from the 3-dayminimumReleaseAgerule so fresh core releases can be installed on ship day.With 0.8.0’s parser fixes, several dialect-specific read statements (e.g. DuckDB
//,TIMESTAMPTZliterals,matchas a table name, SQLiteNOT GLOB) are classified as reads instead of failing closed as writes.sql-executeandsql-classifytests are updated to expect no write-approval prompt and normalsql.executedispatch for those cases; DuckDB//coverage is un-skipped, and malformedstring_aggstill asserts parse-error → write behavior.Reviewed by Cursor Bugbot for commit 9740204. Bugbot is set up for automated code reviews on this repo. Configure here.