Skip to content

fix(lakmus): remove unused armkeyvault/v2 direct dependency#3579

Merged
bengtfredh merged 1 commit into
mainfrom
fix/lakmus-remove-duplicate-armkeyvault
May 26, 2026
Merged

fix(lakmus): remove unused armkeyvault/v2 direct dependency#3579
bengtfredh merged 1 commit into
mainfrom
fix/lakmus-remove-duplicate-armkeyvault

Conversation

@bengtfredh

@bengtfredh bengtfredh commented May 26, 2026

Copy link
Copy Markdown
Member

Summary

Fixes the duplicate entry problem in PR #3576.

armkeyvault/v2 v2.0.2 was added as a direct dependency by Renovate PRs #3536 and #3565, but it is never imported anywhere in the lakmus source — only the v1 package path (armkeyvault without /v2) is used. This left go.mod with both versions listed, causing #3576 to produce a duplicate armkeyvault/v2 v2.0.2 line.

PR #3576 should be closed.

Test plan

  • Check for go vulnerabilities (services/lakmus) passes
  • Lint and Test on Ubuntu passes

Summary by CodeRabbit

  • Chores
    • Updated underlying service dependencies to improve compatibility and stability.

Review Change Stack

armkeyvault/v2 was added as a direct dependency by Renovate PRs #3536
and #3565 but is never imported in any source file — only the v1 package
path is used. This left main with both v1.5.0 and v2.0.2 listed, causing
PR #3576 to produce a duplicate entry.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@bengtfredh bengtfredh requested a review from a team as a code owner May 26, 2026 10:54
@coderabbitai

coderabbitai Bot commented May 26, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 85d8d2d6-eb8b-46ca-af07-0c95c15c62d1

📥 Commits

Reviewing files that changed from the base of the PR and between bea6dab and 71d1ba3.

⛔ Files ignored due to path filters (1)
  • services/lakmus/go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • services/lakmus/go.mod
💤 Files with no reviewable changes (1)
  • services/lakmus/go.mod

📝 Walkthrough

Walkthrough

The PR downgrades the Azure Key Vault ARM SDK dependency in services/lakmus/go.mod from armkeyvault/v2 v2.0.2 to armkeyvault v1.5.0, changing both the module path and version constraint.

Changes

Key Vault ARM Dependency Update

Layer / File(s) Summary
Downgrade armkeyvault from v2.0.2 to v1.5.0
services/lakmus/go.mod
The Key Vault ARM client require entry is downgraded from the v2 major version (2.0.2) to v1 major version (1.5.0), changing the module path accordingly.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • Altinn/altinn-platform#3548: Also modifies services/lakmus/go.mod and removes the armkeyvault/v2 dependency, directly related to the Key Vault SDK version change.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: removing an unused armkeyvault/v2 direct dependency from the lakmus module's go.mod file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/lakmus-remove-duplicate-armkeyvault

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bengtfredh bengtfredh merged commit 7304975 into main May 26, 2026
1 check was pending
@bengtfredh bengtfredh deleted the fix/lakmus-remove-duplicate-armkeyvault branch May 26, 2026 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant