Aws dp 402 perf nfs fuse

[ashahab-altiscale]

No description provided.

[tucker-altiscale]

You should tell OptionParser to expect an Integer here.

opts.on('-t',
        '--times NUM_TIMES',
        Integer,
        'Times to run script, default 1.') do |times|
  settings.times = times
end

[raviprak-altiscale]

Sorry I noticed you comment late Tucker. I've added it in now. Could you please review and merge the branch?

[tucker-altiscale]

Sorry, I think that was actually an incomplete review before. The reason to tell optparser to expect an integer is actually to simplify this. With optparser ensuring the correct data type, you can now do this:

settings.times.times do |i|
  logger.debug "Run: #{i}"
  ...snip...
end

It ends up being simpler an somewhat more readable (although settings.times.times does leave a bit to be desired). This is non blocking though. If you'd prefer to move forward without it, please self merge.