Repository navigation
Add yamllint to workflow-validation CI (Phase 4 #G) - #34
Merged
Merged
Conversation
Extend cicd-workflow-validate beyond a bare PyYAML parse to catch real YAML errors (bad indentation, duplicate keys, tab/space issues) in the CI workflows. .yamllint uses a relaxed config: line-length and document-start disabled and the GitHub Actions `on:` truthy false-positive allowed, so it flags genuine errors without churning the existing (valid) workflows. Verified clean against all current workflows. Follow-ups (#G): actionlint + shellcheck for run: scripts, pin actions to commit SHAs, minimal per-job permissions. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012K5Zjc2bggcyJtFbz2D4Pw
There was a problem hiding this comment.
Pull request overview
This PR strengthens CI workflow validation by adding yamllint with a repo-specific, relaxed configuration, extending validation beyond a basic PyYAML parse to catch real YAML issues (e.g., indentation problems, duplicate keys, tab/space mistakes) across GitHub Actions workflows.
Changes:
- Add a
.yamllintconfiguration tuned for GitHub Actions workflows (disables line-length/document-start; avoidson:truthy key false-positives). - Install
yamllintin thecicd-workflow-validateCI job alongside the existing PyYAML parse step. - Run
yamllintagainst.github/workflows/as part of CI workflow validation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.yamllint |
Adds a relaxed yamllint ruleset intended to catch genuine YAML errors in CI workflows without style churn. |
.github/workflows/ci.yml |
Extends the workflow-validation job to install and run yamllint against .github/workflows/. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends
cicd-workflow-validatebeyond a bare PyYAML parse to catch real YAML errors (indentation, duplicate keys, tab/space) in the CI workflows..yamllintuses a relaxed config — line-length and document-start disabled, and the GitHub Actionson:truthy false-positive allowed — so it flags genuine errors without churning the existing valid workflows. Verified clean against all current workflows.Follow-ups (#G): actionlint + shellcheck for run: scripts, pin actions to commit SHAs, minimal per-job permissions.
https://claude.ai/code/session_012K5Zjc2bggcyJtFbz2D4Pw