Fix minAppVersion: declared 1.0.0, but uses a 1.1.0 API - #53
Merged
Conversation
ButtonComponent.setIcon()/setTooltip() (history manager's delete button, added in the 0.9.71 history-management feature) were both introduced in Obsidian 1.1.0 -- manifest.json's minAppVersion still said 1.0.0, which the obsidianmd/no-unsupported-api linter flagged. Only usage in the codebase; no other API exceeds 1.0.0. 0.9.8 hasn't been released yet, so its versions.json entry is amended in place rather than bumping to a new plugin version. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011AnUmNKkH1y4ZAEPKF1WwQ
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an
obsidianmd/no-unsupported-apilint error:manifest.jsondeclaredminAppVersion: "1.0.0", butHistoryManagerModal's delete button usesButtonComponent.setIcon()/.setTooltip()(src/modals/history-manager-modal.ts:73-75), both introduced in Obsidian 1.1.0. On Obsidian 1.0.x those calls would throw at runtime.Verified it's the only such usage in the codebase (
grep -rn "setIcon\|setTooltip" src/).Changes
manifest.json:minAppVersion1.0.0→1.1.0versions.json:"0.9.8"entry1.0.0→1.1.0(0.9.8 hasn't been released yet, so amending in place rather than bumping to a new version)CHANGELOG.md: added aFixedentry under[0.9.8]Verification
tsc, andnpm run buildall clean.Generated by Claude Code