Skip to content

chore: add Ruff, pre-commit, Commitlint, update README#4

Merged
amitgandhi12 merged 2 commits into
developmentfrom
feature/AB-05600
Dec 12, 2025
Merged

chore: add Ruff, pre-commit, Commitlint, update README#4
amitgandhi12 merged 2 commits into
developmentfrom
feature/AB-05600

Conversation

@ashishverma49

@ashishverma49 ashishverma49 commented Dec 8, 2025

Copy link
Copy Markdown
Collaborator
  • Ruff for Python linting
  • pre-commit hooks to enforce code standards automatically
  • Commitlint to standardize commit messages

Additionally, the README has been updated to document these tools, and the .flake8 file has been removed.

…e-commit, commitlint, and Pylint GitHub Actions, while updating the README and removing .flake8.

Signed-off-by: Ashish Kumar Verma <ashish.verma@ambibuzz.com>
Signed-off-by: Ashish Verma <ashish.verma@ambibuzz.com>
@github-actions

github-actions Bot commented Dec 8, 2025

Copy link
Copy Markdown

Part 1/1

  1. Missing Error Handling: The configuration files do not include any error handling mechanisms. For example, if the pre-commit hooks fail, there is no indication of how to handle those failures or what steps to take next.

  2. Security Vulnerabilities: The pre-commit-config.yaml file includes hooks from external repositories without verifying their integrity or security. This could expose the project to vulnerabilities if any of those repositories are compromised. Consider using specific versions and reviewing the code of these hooks.

  3. Performance Issues: The ruff configuration includes a broad selection of rules without considering the potential performance impact on larger codebases. It may be beneficial to selectively enable only the most relevant rules to improve linting speed.

  4. Logic Errors: The commitlint.config.js file enforces a "Signed-off-by" rule, which may not be appropriate for all projects. This could lead to confusion or errors if contributors are not aware of this requirement.

  5. Excessive Exclusions: The exclusions in both ruff.toml and .pre-commit-config.yaml may inadvertently skip important files that should be linted or formatted, potentially allowing issues to go unnoticed. Ensure that exclusions are necessary and do not compromise code quality.

@ashishverma49 ashishverma49 added the enhancement New feature or request label Dec 8, 2025
@ashishverma49 ashishverma49 changed the title Enhance code quality with new tooling and update README chore: add Ruff, pre-commit, Commitlint, update README Dec 8, 2025
@amitgandhi12 amitgandhi12 merged commit def2505 into development Dec 12, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Development

Successfully merging this pull request may close these issues.

2 participants