[codex] Complete Xiaoan desktop productization readiness - #2
Draft
An-an-525 wants to merge 18 commits into
Draft
Conversation
…t name auto-updater and mac-update-metadata tests still asserted HanaAgent-* paths/filenames while electron-builder emits Xiaoan-* — a coverage blind spot. Align fixtures with the real product name. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
pack/install:local hard-failed without APPLE_ID + APPLE_APP_SPECIFIC_PASSWORD (notarize.cjs threw), blocking local builds while the project is on self-signing. Skip with a hint; CI with secrets still notarizes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
better-sqlite3 is built for Node 24 ABI; Node 26 produces 124 false failures. engines only warns; add a hard pre-test check reading .nvmrc. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Last two non-compat HanaAgent references: a comment in session-coordinator and mock exec paths in office-plugin-tools test. Compat layer (HANA_HOME, @hana/*, hanakoHome, HANA_DESKTOP_* env, hana-* localStorage) kept for legacy dual-read. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR turns Xiaoan into the first-class desktop product surface for this repository. It focuses on productization: default experience, user-facing language, runtime defaults, desktop shell polish, built-in capability surfaces, distribution readiness, and tests/docs guardrails.
This is intentionally not a bottom-up rewrite. The existing agent engine, Pi SDK integration, plugin model, Bridge, and legacy compatibility paths remain in place.
What changed
Important scope note
The full local branch also contains GitHub Actions workflow hardening for macOS signing/notarization gates and Xiaoan release asset verification. GitHub rejected pushing that exact branch because the current OAuth token does not include the
workflowscope.For this uploadable PR,
.github/workflows/build.ymland.github/workflows/ci.ymlare temporarily left atorigin/main, and the workflow-specific macOS contract assertion is deferred. After refreshing GitHub auth withworkflowscope, those workflow changes should be pushed as a small follow-up commit/PR.Validation
npm run typecheckpassed.npm run dep:checkpassed on the full local branch before upload.npm run typechecknpm test -- tests/xiaoan-fork.test.ts tests/xiaoan-runtime-migrate.test.ts tests/xiaoan-layout-theme-contract.test.ts tests/xiaoan-gsap-chat-motion.test.ts tests/windows-installer-contract.test.ts tests/mac-update-metadata-contract.test.ts --reporter=dot.env, certificate, or log file in the staged/uploaded tree.Release notes
Installer signing/notarization and final release publishing still require GitHub repository secrets and Actions workflow changes. The desktop product code is ready for review; final commercial-grade release should wait for signed package verification on CI and Windows/macOS installer smoke tests.
Credits
Xiaoan builds on the repository's existing agent framework and open-source foundations. Upstream lineage and third-party notices remain documented outside the first-screen product narrative.