Repository navigation
STE-68: seed the live demo, and two harness bugs the run exposed - #70
Merged
Merged
Conversation
…lure The first live seed run of STE-68 failed at S.2 with `Trustline for sUSD:GCYJNYCU... not found for ...`. `getAssetBalance` does not answer an account holding no trustline with an empty `balanceEntry`; it throws. S.2 branched on the empty entry, so its `addTrustline` call was unreachable and a run with a freshly created organiser could never pass. Move the read into `trustline.ts`, matching the throw as narrowly as the web app already does in `fe/src/lib/wallet/susd.ts`, so a slow or unhappy node is never read as "this wallet holds nothing". `susdBalance` gains the same treatment: no trustline is a zero balance. The module is free of `@sterunxyz/sdk` so its tests run without the SDK build. Tests pin both halves and run in CI. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Four races and 25 records, the SOW's two fraud attempts among them, seeded in one run of docs/rehearsal/seed.sh: 22 PASS, 0 FAIL, 1 MANUAL REQUIRED of 23. Carries the race and runner URLs a reviewer opens with no wallet, the transaction hashes behind them, and two things that are easy to overstate: F.1 does not prove a forwarded QR is rejected, only that one goes stale in under a minute; and Ancung's seven TESTING races are still on the directory's first screen, which the seed cannot cancel as a non-organiser. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Three runs, kept in the order they happened rather than only the good one: 08-58-15Z-seed 2 PASS, 1 FAIL — the S.2 trustline bug, on live testnet 09-08-01Z-seed 22 PASS, 0 FAIL, 1 MANUAL of 23 — the demo (STE-68) 09-26-21Z 51 PASS, 0 FAIL, 6 MANUAL of 57 — the rehearsal (STE-25) The failed run is kept on purpose: it is what the fix in acc2f90 answers, and a harness that only ever shows its passes is worth less than one that shows what it caught. The rehearsal is up from its 49/0/6 baseline because F.1 (STE-67, a forwarded screenshot going stale) and C.1 (STE-68, cancelling what the run created) are in it now. 61 of 61 transaction links resolve on Horizon and stellar.expert. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…t's status S.2 carried two hardcoded sentences: "no Vercel URL for fe/ or landing-page/ exists anywhere in the repo or docs/deployments.md" and "STE-32 (Vercel deploy) is still Backlog". STE-32 shipped on 2026-09-23, so from that day every run told Ancung to redo a deploy she had already done, and said something false about a file that had carried the deploy's evidence for two days. M.1 and M.2 repeated "a deployed web app (none exists)", and M.4 asked her to "build the public profile (STE-24, Backlog)" nine days after STE-24 was Done. The rehearsal now probes both origins and reports what it measured. A 200 is not the test: sterun.xyz answered 200 for weeks as a Hostinger parked page, and reading that as a live landing page is the same bug pointing the other way. live-site.ts holds the rule, with tests for both directions — including that an empty body is live, because an empty read is a tool limit, not a fact about the site. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this is
The STE-68 demo, seeded on live testnet, plus the two harness bugs that running it for real turned up.
Seed: 22 PASS, 0 FAIL, 1 MANUAL REQUIRED of 23. Four races, 25 records, both SOW fraud attempts.
Rehearsal: 51 PASS, 0 FAIL, 6 MANUAL of 57, and 61 of 61 transaction links resolve. Up from the 49/0/6 baseline because F.1 (STE-67) and C.1 (STE-68) are in it now.
Nine race packs were handed over in one signature (
claim_racepack_many) and twelve results recorded in one (record_results), against the live RaceRecord v2.7. Before STE-66 this run would have needed twenty-one transactions instead of two.Bug 1 — a missing trustline read as a failure (
acc2f90)The first seed attempt failed at S.2.
getAssetBalancedoes not answer an account with no trustline with an emptybalanceEntry; it throwsTrustline for ... not found for .... The step branched on the empty entry, so itsaddTrustlinecall was unreachable and a run with a fresh organiser could never pass.The read moves to
docs/rehearsal/src/trustline.ts, matching the throw as narrowly asfe/src/lib/wallet/susd.tsalready does, so a slow or unhappy node is never read as "this wallet holds nothing".susdBalancegets the same treatment: no trustline is a zero balance.Bug 2 — the harness asserting other tickets' status (
94b4601)S.2 carried two hardcoded sentences: "no Vercel URL for fe/ or landing-page/ exists anywhere in the repo or docs/deployments.md" and "STE-32 (Vercel deploy) is still Backlog".
STE-32 shipped on 2026-09-23. From that day every run told Ancung to redo a deploy she had already done, and said something false about a file that had carried the deploy's evidence for two days. M.1 and M.2 repeated "a deployed web app (none exists)". M.4 asked her to "build the public profile (STE-24, Backlog)" nine days after STE-24 was Done.
S.2 now probes both origins and reports what it measured. A 200 is not the test —
sterun.xyzanswered 200 for weeks as a Hostinger parked page, and reading that as a live landing page is the same bug pointing the other way.docs/rehearsal/src/live-site.tsholds the rule, tested in both directions, including that an empty body counts as live because an empty read is a tool limit, not a fact about the site.Tests
63 rehearsal tests pass, 10 of them new. Both new files are wired into the
typescript.ymlmatrix.Not fixed here, and not ours to fix
Seven races created with Ancung's wallet (events 3, 4, 12, 13, 28, 36, 37) are still on the directory's first screen. There is no delete and only the organiser can cancel, so the seed deliberately left them and said so. Tracked in STE-70.
Evidence
docs/deployments.mdgains a STE-68 section with the URLs and transaction hashes. Three run bundles are committed, including the failed one — it is what the first fix answers, and a harness that only ever shows its passes is worth less than one that shows what it caught.🤖 Generated with Claude Code