Skip to content

Two things seen on the live board: an empty closing-date card, and a finished race among the enterable ones - #72

Merged
AncungAulia merged 2 commits into
mainfrom
fix/overview-close-date-card
Sep 27, 2026
Merged

AncungAulia merged 2 commits into
mainfrom
fix/overview-close-date-card

Conversation

@AncungAulia

Copy link
Copy Markdown
Owner

Both found by opening app.sterun.xyz after #71 deployed, neither by a test.

The closing-date card, when there is no closing date

A race without one read "Anytime, until you close them" in the slot where the other three cards carry a number, wrapped over three lines. That is not a fact about the race, it is the absence of one dressed as a measurement. Every race published before STE-69 has no date on chain, so the card was noise on most of the board and useful on none of it.

Where there is a date it stays: it is the one place an organiser can see what the contract will actually enforce, as opposed to what the event document promises.

A completed race sitting among the races people can enter

A rehearsal race wearing a Finished badge was on the default directory, which hides what is over. Its start time was later the same day, and entryRank read "over" from two things only: Cancelled, or a start time already past. Completed was not one of them, so the race counted as "still ahead".

An organiser marks a race Completed once it has been run and its results are recorded. A start time a few hours away does not make it enterable, and a card saying Finished on a board of things to enter is the directory contradicting itself.

One existing test was locking in the old behaviour (it asserted a Completed race renders on the board), so it now uses Closed, which genuinely is still ahead. Two tests were added: a completed race is off the default board whatever its date, and it comes back with "Show races that have finished".

This also takes the rehearsal race off the board without anybody cancelling it, which matters because it belongs to Axel's wallet rather than Ancung's.

🤖 Generated with Claude Code

https://claude.ai/code/session_01PkgGbz4eNSdzzzAPiqV1ZU

AncungAulia and others added 2 commits September 27, 2026 08:35
A race with no close date read "Anytime, until you close them" in the slot
where the other three cards carry a number. That is not a fact about the race,
it is the absence of one dressed as a measurement, and it wrapped across three
lines saying nothing.

Every race published before STE-69 has no date on chain, so the card was noise
on most of the board and useful on none of it. Where there is a date it stays,
because it is the one place an organiser can see what the contract will
actually enforce.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PkgGbz4eNSdzzzAPiqV1ZU
Spotted on the live board: a rehearsal race wearing a Finished badge, sitting
among races people could still enter. Its start time was later the same day, so
`entryRank` read it as "still ahead" and the default board, which hides what is
over, kept it.

An organiser marks a race Completed once it has been run and its results are
recorded. A start time a few hours away does not make it a race anybody can
enter, and a card that says Finished on a board of things to enter is the
directory contradicting itself.

Cancelled already counted whatever its date; Completed now does too.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PkgGbz4eNSdzzzAPiqV1ZU
@vercel

vercel Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
sterun-app Ready Ready Preview Sep 27, 2026 1:42am UTC
sterun-fe Ready Ready Preview Sep 27, 2026 1:42am UTC
1 Skipped Deployment
Project Deployment Actions Updated
sterun-landing-page Skipped Skipped Sep 27, 2026 1:42am UTC

@AncungAulia
AncungAulia merged commit eda06c4 into main Sep 27, 2026
6 checks passed
@AncungAulia
AncungAulia deleted the fix/overview-close-date-card branch September 27, 2026 01:47

This branch was successfully deployed

2 active and 1 inactive deployments
Preview – sterun-app — e9004866 Deployed Sep 27, 2026 by vercel[bot]
Preview – sterun-fe — e9004866 Deployed Sep 27, 2026 by vercel[bot]
Preview – sterun-landing-page — e9004866 Deployed Sep 27, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant