Repository navigation
Two things seen on the live board: an empty closing-date card, and a finished race among the enterable ones - #72
Merged
Conversation
A race with no close date read "Anytime, until you close them" in the slot where the other three cards carry a number. That is not a fact about the race, it is the absence of one dressed as a measurement, and it wrapped across three lines saying nothing. Every race published before STE-69 has no date on chain, so the card was noise on most of the board and useful on none of it. Where there is a date it stays, because it is the one place an organiser can see what the contract will actually enforce. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PkgGbz4eNSdzzzAPiqV1ZU
Spotted on the live board: a rehearsal race wearing a Finished badge, sitting among races people could still enter. Its start time was later the same day, so `entryRank` read it as "still ahead" and the default board, which hides what is over, kept it. An organiser marks a race Completed once it has been run and its results are recorded. A start time a few hours away does not make it a race anybody can enter, and a card that says Finished on a board of things to enter is the directory contradicting itself. Cancelled already counted whatever its date; Completed now does too. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PkgGbz4eNSdzzzAPiqV1ZU
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both found by opening
app.sterun.xyzafter #71 deployed, neither by a test.The closing-date card, when there is no closing date
A race without one read "Anytime, until you close them" in the slot where the other three cards carry a number, wrapped over three lines. That is not a fact about the race, it is the absence of one dressed as a measurement. Every race published before STE-69 has no date on chain, so the card was noise on most of the board and useful on none of it.
Where there is a date it stays: it is the one place an organiser can see what the contract will actually enforce, as opposed to what the event document promises.
A completed race sitting among the races people can enter
A rehearsal race wearing a Finished badge was on the default directory, which hides what is over. Its start time was later the same day, and
entryRankread "over" from two things only:Cancelled, or a start time already past.Completedwas not one of them, so the race counted as "still ahead".An organiser marks a race Completed once it has been run and its results are recorded. A start time a few hours away does not make it enterable, and a card saying Finished on a board of things to enter is the directory contradicting itself.
One existing test was locking in the old behaviour (it asserted a Completed race renders on the board), so it now uses
Closed, which genuinely is still ahead. Two tests were added: a completed race is off the default board whatever its date, and it comes back with "Show races that have finished".This also takes the rehearsal race off the board without anybody cancelling it, which matters because it belongs to Axel's wallet rather than Ancung's.
🤖 Generated with Claude Code
https://claude.ai/code/session_01PkgGbz4eNSdzzzAPiqV1ZU