refactor: remove StateTuple - #14
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the internal StateTuple pooled reference-tuple implementation from the Unity package, along with its associated runtime tests and Unity .meta asset, simplifying the internal surface area.
Changes:
- Deleted
StateTupleimplementation underRuntime/Internal. - Removed
StateTuple-specific unit tests and an unusedusingfromUniTaskPlusTests.cs. - Removed the Unity
.metafile corresponding to the deleted C# source file.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/UniTaskPlus.Unity/Packages/jp.andantetribe.unitaskplus/Tests/Runtime/UniTaskPlusTests.cs | Removes StateTuple tests and the now-unneeded using UniTaskPlus;. |
| src/UniTaskPlus.Unity/Packages/jp.andantetribe.unitaskplus/Runtime/Internal/StateTuple.cs | Deletes the StateTuple pooled tuple implementation. |
| src/UniTaskPlus.Unity/Packages/jp.andantetribe.unitaskplus/Runtime/Internal/StateTuple.cs.meta | Removes the Unity asset metadata for the deleted source file. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.