Skip to content

Conversation

@sarah-quinones
Copy link

switch to core and alloc instead of std. also use hashbrown hashmap and hashset instead of the one from std

@Andlon
Copy link
Owner

Andlon commented Feb 20, 2024

Thanks @sarah-ek, that's great. Seems like you're missing the actual hashbrown dep in Cargo.toml?

Also, is the motivation for using hashbrown simply that it supports no-std? My understanding is that HashMap/HashSet from std are not no-std compatible because they need a source of randomness for security purposes. Do you know how hashbrown handles this? I couldn't dig up docs on how hashbrown differs for the no-std case. I can't quite imagine matrixcompare being used in a place where this could become an issue, but I don't know. Do you have any thoughts on this?

@sarah-quinones
Copy link
Author

the randomness is there to prevent DOS attacks, which seems unlikely to me with sparse matrices?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants