Resolve Sonar findings (#279) - #27
Closed
devin-ai-integration[bot] wants to merge 1 commit into
Closed
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Andreas Igel <andreas.igel@computacenter.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
AndreasIgel
changed the base branch from
main
to
devin/1788589722-fork-sonar-232
September 5, 2026 15:18
AndreasIgel
changed the base branch from
devin/1788589722-fork-sonar-232
to
main
September 5, 2026 15:18
Owner
|
moved to java-helpers#282 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the three code-level Sonar findings from java-helpers#279 (the
fork-sonar.ymluntrusted-fork hotspot is intentionally left for its own ticket). No behavior changes.ProcessorTestUtils.extractTopLevelTypeName— regex with super-linear backtracking (^\s*(?:mod)?(?:\s+(?:mods))*\s*stacks whitespace quantifiers). Now each modifier consumes its own trailing whitespace,^[ \t]*no longer spans lines, and both patterns in the file arestatic final Patternconstants instead of being compiled per call:RoasterCodeGenerator.addParameter— conditional moved inside the operation; onevarArgsboolean replaces twoinstanceofchecks:ConfigurationProcessingTest.allConfigurationOptions_MustBeSettableViaBuilder— 27 assertions > 25 limit. The builder chain moved intobuildFullyConfigured(); theOptionStateassertions stay in the original test and theAccessModifier/suffix/formattingModeassertions moved toallConfigurationOptions_AccessNamingAndFormatting_MustBeReadable. No assertion dropped.Processor module: 420 tests green. Generated example builders unchanged (CI drift check passes).
Link to Devin session: https://app.devin.ai/sessions/d691231fba0842a4b842b275ca4b35ed
Open in Devin Desktop: https://app.devin.ai/desktop/session/d691231fba0842a4b842b275ca4b35ed?variant=devin
Requested by: @AndreasIgel