Support -D system properties for compiler options (#275) by devin-ai-integration[bot] · Pull Request #29 · AndreasIgel/simple-builders-fork

devin-ai-integration · 2026-09-05T06:45:46Z

Summary

mvn compile -Dsimplebuilder.<option>=<value> (and the Gradle equivalent) now works without a -Asimplebuilder.<option>=${simplebuilder.<option>} mapping in the build file. Previously the docs suggested it did, but the processor only read processingEnv.getOptions() (i.e. -A args), so -D alone was silently ignored (java-helpers#275).

CompilerArgumentsReader.readValue now resolves:

value = System.getProperty("simplebuilder.<opt>");   // -D  (new, highest)
if (value == null) value = options.get("simplebuilder.<opt>");  // -A, prefixed
if (value == null) value = options.get("<opt>");                // -A, bare (legacy)

The system property is checked first: -A args from pom.xml/build.gradle and from the CLI land in the same javac option map, so a -D given on the command line would otherwise never be able to override a setting configured in the build file. Only the prefixed name is looked up as a system property — a bare -Dverbose=true is deliberately ignored to avoid colliding with unrelated JVM properties. Since every option goes through readValue, this covers all of readBuilderConfiguration, verbose, performanceTracking* and deactivateGenerationComponents at once.

Effective precedence: @SimpleBuilder.Options > -D system property > -A compiler arg > default.

Verified end-to-end (not committed): Maven mvn -pl example clean compile -D… changes the generated builders; Gradle 8.10 with the default in-process compiler (-D… on the CLI or systemProp.simplebuilder.… in gradle.properties) does too. It does not work with forked javac (<fork>true</fork> / options.fork = true) or IDE builds — -A remains required there — and Gradle does not treat the property as a task input (compileJava stays UP-TO-DATE without clean/--rerun-tasks). All of this is documented in docs/CONFIGURATION.md / docs/DEBUG_LOGGING.md.

Tests: three CompilerArgumentsReaderTest cases (fallback, -D wins over -A, bare-name property ignored).

Closes java-helpers#275.

Link to Devin session: https://app.devin.ai/sessions/d691231fba0842a4b842b275ca4b35ed
Open in Devin Desktop: https://app.devin.ai/desktop/session/d691231fba0842a4b842b275ca4b35ed?variant=devin
Requested by: @AndreasIgel

…lpers#275) Co-Authored-By: Andreas Igel <andreas.igel@computacenter.com>

devin-ai-integration · 2026-09-05T06:45:50Z

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

Disable automatic comment, CI, and merge conflict monitoring

AndreasIgel · 2026-09-05T15:22:57Z

+    if (value == null) {
+      value = System.getProperty(argument.getCompilerArgument());
+    }
+


I guess the ordering is wrong, right? I I am executing it with -A or with -D it both should have a higher priority then the config in pom.xml!? Otherwise you can not just check things, you always would need to change pom.xml?

You're right — -A from pom.xml and -A from the CLI land in the same javac option map, so with the old order a -D could never override a pom setting. Changed in e30c859: precedence is now -D system property > prefixed -A > bare-name -A, test inverted (readValue_CompilerArgAndSystemPropertySet_PrefersSystemProperty), docs updated.

Also corrected the docs regarding Gradle: I verified that -Dsimplebuilder.<option> works with Gradle too (default in-process compiler, and via systemProp.… in gradle.properties); it only fails with options.fork = true, and Gradle doesn't treat the property as a task input (needs clean/--rerun-tasks).

…ers#275) Co-Authored-By: Andreas Igel <andreas.igel@computacenter.com>

AndreasIgel · 2026-09-05T18:13:46Z


+### Command Line (-D)
+
+Maven supports compiler options without a `pom.xml` change, for example: `mvn compile -Dsimplebuilder.generateJavaDoc=DISABLED`.


Not only maven here

Fixed: "Maven and Gradle accept the options as JVM system properties without a build-file change", with a mvn and a gradle compileJava example (9f012cd).

AndreasIgel · 2026-09-05T18:14:23Z


-1. **Check option names**: Ensure you're using the full option name (e.g., `-Asimplebuilder.generateFieldSupplier`)
+1. **Check option names**: Ensure you're using the full option name (e.g., `-Asimplebuilder.generateFieldSupplier`); Maven also supports the `-Dsimplebuilder.<option>` fallback
 2. **Verify processor is running**: Ensure annotation processor is configured correctly


It is not the fallback, it is the default. And it is not maven only.

Fixed: now "the same name also works as a JVM system property (-Dsimplebuilder.<option>), which takes precedence over -A" — no "fallback", no Maven-only wording (9f012cd).

AndreasIgel · 2026-09-05T18:15:26Z

  public String readValue(CompilerArgumentsEnum argument) {
-    // Try with full compiler argument name first (e.g., "simplebuilder.verbose")
-    String value = processingEnv.getOptions().get(argument.getCompilerArgument());
+    // Try the prefixed JVM system property first (e.g., "simplebuilder.verbose")


Naming, that this is the -D option?

Now explicitly labelled: -Dsimplebuilder.generateFieldSupplier=true (JVM system property, highest precedence), -Asimplebuilder.… (compiler argument), -AgenerateFieldSupplier=true (bare option name, backward compatibility). 9f012cd.

AndreasIgel · 2026-09-05T18:16:04Z

+    String value = System.getProperty(argument.getCompilerArgument());

-    // Fall back to simple option name for backward compatibility (e.g., "verbose")
+    // Fall back to the full compiler argument name (e.g., "simplebuilder.verbose")


Why naming here "full" compiler argument? Isn't it just the compiler argument?

Agreed, "full" was misleading. Comments now read: -D JVM system property → -A compiler argument → bare option name (backward compatibility). 9f012cd.

AndreasIgel · 2026-09-05T18:17:52Z

   * <ul>
   *   <li>{@code -Asimplebuilder.generateFieldSupplier=true}
+   *   <li>{@code -Dsimplebuilder.generateFieldSupplier=true} as a system-property alternative
   *   <li>{@code -Asimplebuilder.builderAccess=public}
   *   <li>etc.


-D first, because it is handled first? And what about the option name? And where are the option from
Annotations handled? On different place?

Yes, -D is checked first because it must win: build-file -A options and command-line -D both reach the processor, and only this order lets a CLI -D override the pom/gradle setting without editing it. The bare option name (-Averbose) is the last lookup for backward compatibility. Annotation options are not handled here at all: BuilderConfigurationReader reads @SimpleBuilder.Options per annotated type and merges them on top of this global configuration, giving @Options > -D > -A > default. The readBuilderConfiguration Javadoc now lists all three forms in precedence order and states where annotation options are handled (9f012cd).

Co-Authored-By: Andreas Igel <andreas.igel@computacenter.com>

AndreasIgel · 2026-09-12T17:46:13Z

moved to java-helpers#287

feat: fall back to -D system properties for compiler options (java-he…

ab8a052

…lpers#275) Co-Authored-By: Andreas Igel <andreas.igel@computacenter.com>

devin-ai-integration Bot assigned AndreasIgel Sep 5, 2026

AndreasIgel reviewed Sep 5, 2026

View reviewed changes

fix: let -D system property override -A compiler arguments (java-help…

e30c859

…ers#275) Co-Authored-By: Andreas Igel <andreas.igel@computacenter.com>

devin-ai-integration Bot changed the title ~~Fall back to -D system properties for compiler options (#275)~~ Support -D system properties for compiler options (#275) Sep 5, 2026

AndreasIgel reviewed Sep 5, 2026

View reviewed changes

docs: clarify -D option wording (java-helpers#275)

9f012cd

Co-Authored-By: Andreas Igel <andreas.igel@computacenter.com>

AndreasIgel closed this Sep 12, 2026

AndreasIgel deleted the devin/1788590630-sysprop-fallback-275 branch September 12, 2026 19:22


		### Command Line (-D)

		Maven supports compiler options without a `pom.xml` change, for example: `mvn compile -Dsimplebuilder.generateJavaDoc=DISABLED`.

Conversation

devin-ai-integration Bot commented Sep 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

devin-ai-integration Bot commented Sep 5, 2026

🤖 Devin AI Engineer

Uh oh!

AndreasIgel Sep 5, 2026

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot Sep 5, 2026

Choose a reason for hiding this comment

Uh oh!

AndreasIgel Sep 5, 2026

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot Sep 6, 2026

Choose a reason for hiding this comment

Uh oh!

AndreasIgel Sep 5, 2026

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot Sep 6, 2026

Choose a reason for hiding this comment

Uh oh!

AndreasIgel Sep 5, 2026

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot Sep 6, 2026

Choose a reason for hiding this comment

Uh oh!

AndreasIgel Sep 5, 2026

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot Sep 6, 2026

Choose a reason for hiding this comment

Uh oh!

AndreasIgel Sep 5, 2026

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot Sep 6, 2026

Choose a reason for hiding this comment

Uh oh!

AndreasIgel commented Sep 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

devin-ai-integration Bot commented Sep 5, 2026 •

edited

Loading