chore: migrate toolchain to mise, harden CI, fix docs + JSP cookie bug#71
Merged
Merged
Conversation
Foundation (Phase A): - Add .mise.toml pinning java/maven/node/act (single toolchain source) - Makefile: replace SDKMAN+nvm with mise; drop sudo/curl-install targets, @clear; honest lint desc; renovate-validate via renovate@latest + mise node - ci.yml: jdx/mise-action with per-leg MISE_JAVA_VERSION; add changes (dorny/paths-filter) + ci-pass aggregator; rename job ci->build; m2 cache; workflow_call trigger - renovate.json: automergeType branch->pr; enable mise manager Docs (Phase B): - README/CLAUDE.md: mise prerequisites, remove deleted-target refs, fix tomcat10 Servlet API 6.0->6.1, rewrite CI section, size screenshots Fix: - index.jsp: render all cookies (was only rendering the last)
This was referenced Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Project-review remediation — Phase A (foundation) + Phase B (docs), all validated locally.
Foundation (Phase A)
.mise.toml(new) — pinsjava(temurin-21),maven3.9.11,node24.16.0,aqua:nektos/act0.2.87 as the single toolchain source (portfolio mise policy).deps→mise install; removed SDKMAN/nvm/sudo/curl-installtargets (deps-check,env-check,deps-ci,deps-act,renovate-bootstrap); added mise-shimsPATHexport; removed@clear;.PHONYto end; honestlintdescription;renovate-validate→renovate@latestvia mise node.jdx/mise-action+ per-matrix-legMISE_JAVA_VERSIONoverride (replacessetup-java/make deps-ci); addedci-passaggregator +changespath-filter (dorny/paths-filter, SHA-pinned) +pull-requests: read; jobci→build;~/.m2cache;workflow_call:trigger.automergeType: branch→pr; enabledmisemanager.Docs (Phase B, re-derived from post-Phase-A state)
6.0→6.1(pom declares 6.1.0); rewrote CI section; sized screenshots;make testno-op noted; Skills glob*.yml→*.{yml,yaml}.Fix
index.jsp— cookie loop now renders all cookies (the<tr>was outside thefor, so only the last cookie displayed).Validation
make verify-all(all 3 profiles compile under mise) ✓make ci(deps→clean→lint→build→test) → exit 0 ✓actionlint ci.ymlclean ✓ ·make renovate-validateexit 0,misemanager recognized ✓automergeType: pris only safe behind a required status check — addci-passas the required check onmasterafter merge.Not included (deferred)
trivy-fs/cve-check/Checkstyle, realstatic-check) — MEDIUM, separate PR./test-coverage-analysis.