Resolve GGUF artifact links#138
Open
hannibal-lee wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Fixes #137.
Some recommendations are scored as an official base model plus a GGUF quantization, but the actual GGUF files may live in a third-party repo. The output previously linked only to the base model repo, so
users could click a
Q3_K_Mrecommendation and land on a repo that does not contain that GGUF artifact.Testing
pytest)Manual verification:
git diff --check.python -m compileall src/whichllm tests/test_artifacts.py tests/test_markdown_output.py tests/test_cli.py.pytestlocally becauseuv run pytestfailed while buildingpyarrow==23.0.1, and the local Python environments do not havepytestinstalled.Notes
This keeps ranking based on the recommended/base model, but exposes the resolved GGUF artifact repo and filename for output/download surfaces.