fix(standup): eliminate N+1 query pattern in feedback retrieval#20
Closed
AngryJay91 wants to merge 2 commits intomainfrom
Closed
fix(standup): eliminate N+1 query pattern in feedback retrieval#20AngryJay91 wants to merge 2 commits intomainfrom
AngryJay91 wants to merge 2 commits intomainfrom
Conversation
- MockupEditorPage: Lock/Unlock icons were rendered as literal strings
inside mustache {{ }} instead of as Vue components. Fixed by using
v-if/v-else with <Icon> components directly in the template.
- MockupListPage: Desktop viewport icon was a string literal
'<Icon name="monitor" />' inside {{ }}. Fixed by using v-if/v-else
with proper <Icon> component rendering alongside the mobile 📱 emoji.
Closes #17
…oubleshooting - Add detailed command reference for init, hydrate, deploy, migrate, doctor - Document --platform option with supported values (claude-code, codex, gemini) - Add Troubleshooting section covering common setup/runtime issues - Fix CLI reference to include deploy and migrate commands (were missing) Closes #16
Owner
Author
|
Branch contaminated with unrelated changes. Will recreate from clean main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #14 — N+1 query pattern when fetching standup feedback for all entries in a sprint.
Problem
When viewing standup feedback for a sprint, callers had to:
GET /standup/entries?sprint=X→ N rowsGET /standup/feedback?standup_entry_id=N× N → N separate DB queriesSolution
API changes
GET /standup/entries-with-feedback?sprint=— returns entries with feedback embedded. Uses 2 queries total (entries + one IN-clause batch for feedback), regardless of member count.GET /standup/feedback?sprint=(sprint-only mode) — batch fetch all feedback for a sprint in one query.MCP tool changes
list_standup_entries_with_feedback— batch retrieval, preferred over callingget_standup_feedbackper entry.get_standup_feedbacknow supports sprint-only parameter for batch mode.No breaking changes