Skip to content

update assigned moderators list behavior#286

Merged
steryokhin merged 4 commits intodevelopfrom
feature/EPMEDU-1839-assigned-moderators-followup
Feb 15, 2026
Merged

update assigned moderators list behavior#286
steryokhin merged 4 commits intodevelopfrom
feature/EPMEDU-1839-assigned-moderators-followup

Conversation

@Giorgi217
Copy link
Copy Markdown
Collaborator

@Giorgi217 Giorgi217 commented Feb 4, 2026

Pull Request overview

Assigned Moderators: Show All + Expand / Collapse


Problem

  • Moderators section behavior was limited
  • Icon-only interactions were not self-explanatory
  • No "Show All" action with total count
  • Expand / collapse behavior was inconsistent

Summary

  • Added localized Show All (count) action
  • Introduced explicit expand / collapse behavior via chevron toggle
  • ViewModel now owns all moderators display logic
  • Model returns full moderators list without UI limits

Changes

File What changed
Strings.swift Added L10n.Action.showAll(_:) localization
FeedingPointDetailsModel.swift Removed hard list limit; return full moderators list
FeedingPointDetailsViewController.swift Added Show All (count) button and chevron expand/collapse
FeedingPointDetailsViewMapper.swift Added isExpanded to moderators mapping
FeedingPointDetailsContract.swift Added tapToggleModeratorsVisibility event
FeedingPointDetailsViewModel.swift Centralized expand/collapse/show-all logic

How it works

  • Model fetches and maps all moderators
  • ViewModel controls expanded vs collapsed state
  • Preview is shown until "Show All" is tapped
  • Chevron reflects current expansion state

How to test

Moderator / Admin

  • Open Feeding Point Details
  • Verify:
    • Moderators section is visible
    • Show All (N) appears when total > preview limit
    • Tapping Show All reveals all moderators
    • Chevron toggles expand/collapse correctly

Volunteer

  • Moderators section remains hidden
  • No behavior change
Simulator Screenshot - iPhone 15 Pro - 2026-02-04 at 16 11 20 Simulator Screenshot - iPhone 15 Pro - 2026-02-04 at 16 11 11 Simulator Screenshot - iPhone 15 Pro - 2026-02-04 at 16 11 42 Simulator Screenshot - iPhone 15 Pro - 2026-02-04 at 16 11 31

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request enhances the moderators list behavior in the Feeding Point Details screen by introducing explicit expand/collapse functionality with a chevron icon and a "Show All" action with a count indicator. Previously, the moderators section had limited and unclear interaction patterns.

Changes:

  • Added localized "Show All (count)" action button to reveal all moderators when the list exceeds 5 items
  • Introduced chevron toggle for expanding/collapsing the entire moderators section
  • Centralized moderators display logic in the ViewModel with new state management for expansion and "Show All" interactions
  • Modified Model to return full moderators list without hard-coded limits

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
Strings.swift Added showAll(_:) localization function with count parameter
FeedingPointDetailsModel.swift Removed 10-item limit; now returns complete moderators list
FeedingPointDetailsViewController.swift Implemented "Show All" button and chevron expand/collapse UI
FeedingPointDetailsViewMapper.swift Added isExpanded parameter to moderators mapping
FeedingPointDetailsContract.swift Added tapToggleModeratorsVisibility event
FeedingPointDetailsViewModel.swift Implemented expand/collapse state management with "Show All" logic
sheet.csv Added localization entries for new strings
en.lproj/Localizable.strings Added English translation and updated "About Us" to "About"
ka.lproj/Localizable.strings Added Georgian translation for "Show All"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@steryokhin
Copy link
Copy Markdown
Collaborator

Forgot to submit review :(

@steryokhin steryokhin merged commit 1c51c65 into develop Feb 15, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants