Skip to content

EPMEDU-4846: Pet's icon on the map is unclickable#288

Merged
kishorepran merged 3 commits intodevelopfrom
bug/EPMEDU-4846-wrong-sorting-of-feeding-points
Feb 25, 2026
Merged

EPMEDU-4846: Pet's icon on the map is unclickable#288
kishorepran merged 3 commits intodevelopfrom
bug/EPMEDU-4846-wrong-sorting-of-feeding-points

Conversation

@steryokhin
Copy link
Copy Markdown
Collaborator

@steryokhin steryokhin commented Feb 17, 2026

Fixes tap handling on the Home map by prioritizing the closest annotation to the user’s tap, addressing cases where multiple annotations are detected for a single tap (e.g., overlapping markers).

Screenshot 2026-02-17 at 19 28 07
  • sort detected tapped annotations by distance to the tap coordinate before forwarding to the Home module.

- calculate distance to closes point when detecting feeding point clicks
Copilot AI review requested due to automatic review settings February 17, 2026 18:31
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes tap handling on the Home map by prioritizing the closest annotation to the user’s tap, addressing cases where multiple annotations are detected for a single tap (e.g., overlapping markers).

Changes:

  • Track the last map tap screen location via a tap gesture recognizer.
  • Sort detected tapped annotations by distance to the tap coordinate before forwarding to the Home module.
  • Update HomeViewController to act only on the closest (first) tapped annotation id.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
animeal/src/Flows/Main/Modules/Home/Main/View/NavigationMapController.swift Captures tap location and sorts tapped annotations by proximity to the tap.
animeal/src/Flows/Main/Modules/Home/Main/View/HomeViewController.swift Uses only the closest tapped annotation id when dispatching .tapFeedingPoints.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Collaborator

@Giorgi217 Giorgi217 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks good and no blocking issues found. nice work 👍

@kishorepran
Copy link
Copy Markdown
Collaborator

kishorepran commented Feb 25, 2026

Good to go. Much awaited feature. Thanks
would recommend to plan for Swift 6 and modern concurrency migration as well.
this pr increases swift 6 concurrency warnings.

@kishorepran kishorepran merged commit 8760d7c into develop Feb 25, 2026
2 checks passed
@kishorepran kishorepran deleted the bug/EPMEDU-4846-wrong-sorting-of-feeding-points branch February 25, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants