EPMEDU-4846: Pet's icon on the map is unclickable#288
Merged
kishorepran merged 3 commits intodevelopfrom Feb 25, 2026
Merged
Conversation
- calculate distance to closes point when detecting feeding point clicks
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes tap handling on the Home map by prioritizing the closest annotation to the user’s tap, addressing cases where multiple annotations are detected for a single tap (e.g., overlapping markers).
Changes:
- Track the last map tap screen location via a tap gesture recognizer.
- Sort detected tapped annotations by distance to the tap coordinate before forwarding to the Home module.
- Update
HomeViewControllerto act only on the closest (first) tapped annotation id.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
animeal/src/Flows/Main/Modules/Home/Main/View/NavigationMapController.swift |
Captures tap location and sorts tapped annotations by proximity to the tap. |
animeal/src/Flows/Main/Modules/Home/Main/View/HomeViewController.swift |
Uses only the closest tapped annotation id when dispatching .tapFeedingPoints. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
animeal/src/Flows/Main/Modules/Home/Main/View/NavigationMapController.swift
Show resolved
Hide resolved
animeal/src/Flows/Main/Modules/Home/Main/View/NavigationMapController.swift
Outdated
Show resolved
Hide resolved
animeal/src/Flows/Main/Modules/Home/Main/View/NavigationMapController.swift
Show resolved
Hide resolved
Giorgi217
approved these changes
Feb 25, 2026
Collaborator
Giorgi217
left a comment
There was a problem hiding this comment.
everything looks good and no blocking issues found. nice work 👍
AniMosiashvili
approved these changes
Feb 25, 2026
Collaborator
|
Good to go. Much awaited feature. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes tap handling on the Home map by prioritizing the closest annotation to the user’s tap, addressing cases where multiple annotations are detected for a single tap (e.g., overlapping markers).