Skip to content

Audit unresolved native robustness review findings #176

Closed

Description

@Anionix

Context

Merged PR review threads identified several native robustness issues that are not covered by the FastLanes evidence fixes in #169, #170, or #174. They must remain explicit follow-up work rather than disappearing with the merged PRs.

Follow-ups

These findings are retained as review evidence from merged PRs #144, #146, #147, #148, and #149. They do not change the existing format rankings until fixed and re-run.

Activity

  1. Anionix commented on Jul 16, 2026

    @Anionix
    OwnerAuthor

    Additional merged-review findings

    The audit also found these older robustness findings. They remain follow-up work and do not change published rankings until fixed and re-run:

  2. Anionix commented on Jul 16, 2026

    @Anionix
    OwnerAuthor

    More historical robustness findings

  3. Anionix commented on Jul 16, 2026

    @Anionix
    OwnerAuthor

    Post-merge review findings to carry into follow-up fixes:

    • PR Harden robustness evidence contracts #178: verify_roundtrip() operational exceptions such as OSError, RuntimeError, or KeyError are currently classified as VALUE_MISMATCH. Only a confirmed unequal comparison should use that outcome; unexpected adapter/verifier failures need incomplete/harness evidence.
    • PR Harden robustness evidence contracts #178: seeded generated cases with rows == 0 currently record cardinality == 1, although the materialized table has zero values. Persist zero or mark the dimension not applicable.
    • PR Classify native target failures separately #177: the native workflow's failure gate must include the new TARGET_FAILED outcome, or gate directly on the recorded FAIL verdict, so project-seeded target failures cannot publish as green.

    These are tracked before resolving the merged review threads; each will be fixed in a fresh PR from origin/main.

  4. Anionix commented on Jul 16, 2026

    @Anionix
    OwnerAuthor

    Native target failure classification and gate

    PR #177 and its follow-up PR #179 are merged on main.

    • FastLanes/project-seeded non-zero exit is now TARGET_FAILED with verdict FAIL.
    • Signal and timeout remain CRASHED/TIMED_OUT.
    • Arrow/Vortex coverage-guided runner/setup errors remain HARNESS_FAILED/INCOMPLETE.
    • The Linux native workflow now includes TARGET_FAILED in its final failure gate, after evidence upload.

    Verification passed: actionlint, Ruff, Pyright, full pytest, and CI verify. The remaining #176 candidate is the corpus-path behavior for non-fixture Arrow/Vortex native runs; it should be handled in a separate fresh PR.

  5. Anionix commented on Jul 16, 2026

    @Anionix
    OwnerAuthor

    Post-merge review follow-up for PR #179:

    • The native workflow treated every TARGET_FAILED as a job failure, including fastlanes-quick-fuzz, whose target tier is EXPERIMENTAL.
    • PR Keep experimental native failures non-blocking #182 changes the workflow gate to fail only for CORE cases with a bad observed outcome or FAIL verdict. Experimental failures remain durable evidence without blocking publication.

    The merged review thread is being resolved with this follow-up linked.

  6. Anionix commented on Jul 16, 2026

    @Anionix
    OwnerAuthor

    Native corpus directory fixed

    PR #181 is merged on main.

    • Arrow binary-backed coverage-guided targets now receive a dedicated seed directory instead of a single seed file.
    • The exact copied seed directory is retained as corpus_records with SHA-256 values in native evidence.
    • The source seed path and evidence directory are recorded separately.
    • Vortex remains on its official cargo fuzz run path.

    Verification passed: Ruff, Pyright, full pytest, and CI verify. The two concrete implementation issues identified in #176 are now fixed. The Issue remains open for any future native-runner findings, but no further bounded fix is pending from the current audit.

  7. Anionix commented on Jul 16, 2026

    @Anionix
    OwnerAuthor

    Audit complete

    PR #182 is merged on main (82be13e). The native publication gate is now tier-aware:

    Together with #177, #179, and #181, the concrete findings audited by this Issue are fixed and verified by CI. Closing #176.

  8. Anionix commented on Jul 16, 2026

    @Anionix
    OwnerAuthor

    Post-merge review follow-ups:

    Both findings remain tracked here before resolving the merged review threads.

  9. Anionix commented on Jul 16, 2026

    @Anionix
    OwnerAuthor

    Post-merge review follow-up for PR #183:

    • The empty-row cardinality fix changed the seeded PRNG sequence by skipping the cardinality draw when rows == 0.
    • PR Preserve generated case seed sequence #186 will consume the original cardinality draw and then overwrite only the empty case with zero, preserving all subsequent generated cases for the same seed/count.

    This is recorded before resolving the merged review thread.

  10. Anionix commented on Jul 16, 2026

    @Anionix
    OwnerAuthor

    Audit closeout

    PR #186 is merged on main (97c49d3). The generated-case fix now consumes the cardinality PRNG draw even for zero-row cases, so later cases remain identical for the same seed/count.

    The concrete post-merge findings tracked here from #177 through #183 are implemented and verified. Merged review threads are resolved or outdated. The remaining open format work is limited to the explicit reproducibility blockers in #38, #39, and #40.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions