Skip to content

Type adapter workload contracts - #501

Merged
Anionix merged 1 commit into
mainfrom
codex/issue-298-workload-contract
Jul 24, 2026
Merged

Anionix merged 1 commit into
mainfrom
codex/issue-298-workload-contract

Conversation

@Anionix

@Anionix Anionix commented Jul 24, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • replace the adapter manifest workload dict[str, object] boundary with discriminated typed workload declarations
  • preserve the operator and scalar types through the runtime WorkloadSpec boundary
  • reject missing, unsupported, or non-scalar filter predicates before execution

Evidence

  • PYTHONPATH=src /Users/st/Documents/data-format-lab/.venv/bin/pytest tests/test_adapter_contract.py tests/test_workloads.py tests/test_model.py (41 passed)
  • uvx ruff check on changed Python/test files (passed)
  • uvx pyright (0 errors, 0 warnings)
  • independent code-review skill: Standards 0 findings; Spec 0 findings at rebased head 63140f9ac77cb4732819c44d865f421ea310fce5
  • base CI race discovered by the prior run was tracked as bug [bug] Serialize run-parent directory creation across parallel lanes #502 and fixed/verified on main by PR Fix parallel run-parent creation race #503 before this rebase
  • NO_LEAN: no Lean sources or theorem boundary changed

Fixes #298

@Anionix
Anionix force-pushed the codex/issue-298-workload-contract branch from 0e63226 to 63140f9 Compare July 24, 2026 07:34
@Anionix
Anionix merged commit 6804f19 into main Jul 24, 2026
6 checks passed
@Anionix
Anionix deleted the codex/issue-298-workload-contract branch July 24, 2026 07:44

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 63140f9ac7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/format_bench/model.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DFL-AUDIT-100] Adapter API typing

1 participant