load and flatten stylebank.json (1/3 for #24) - #47
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First slice of #24 (including stylebank.json).
Adds
diversify_text/styles/load.py: reads the packagedstylebank.jsonviaimportlib.resourcesand flattens the nested taxonomy into the flatname → examplesdict the rest of the code expects. The JSON is never modified. All shaping happens at load time, including cleaning the two leaf names with awkward characters (barbadian_creole_(bajan)→barbadian_creole,education_somehighschool,nodiploma→education_some_highschool_no_diploma). Duplicate leaf names and malformed leaves fail loudly.Nothing is wired up yet:
DEFAULT_STYLE_BANKis unchanged. The swap comes in the next PR.