Fix/network browse seller 596#597
Open
twfhyr wants to merge 1 commit into
Open
Conversation
…rowse - Add 'On-chain seller' column to browse table when any peer has a sellerContract that differs from its peerId (delegated/proxy sellers) - Column is conditionally shown only when relevant, preserving compact layout for non-delegated sellers - Add sellerAddress and isDelegatedSeller to JSON output for both browse and peer commands - In peer detail view, show 'On-chain seller' with attribution note explaining that channel stats/payments go to the seller address - Preserve all pin/connect semantics around peer.peerId Closes AntSeed#596
74876e3 to
9219568
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds explicit on-chain seller distinction to
antseed network browseandantseed network peerCLI commands. When a peer operates as a delegated/proxy seller (i.e.metadata.sellerContractdiffers frompeerId), the actual on-chain seller address is now surfaced separately from the peer/operator identity.Changes
antseed network browsesellerContractthat differs from itspeerId—in the column; column is hidden entirely when no delegated sellers are present--services) tables include the column--json) addssellerAddressandisDelegatedSellerper peerantseed network peer <id>sellerAddressandisDelegatedSellerfieldsAll pin/connect semantics (
--peer,x-antseed-pin-peer) remain tied topeer.peerId— unchanged.Why
Issue #596 —
antseed network browsepreviously displayedpeer.peerIdas the visible seller identity. For delegated/proxy sellers (e.g. Venice-style setups),peerIdis the operator EOA/node identity, while the actual on-chain seller is carried inpeer.metadata.sellerContract. This made delegated sellers look visually wrong: the browse table showed the operator wallet as the seller, even though channel accounting and payments correctly used the seller contract address. The CLI presentation hid that distinction, making delegated/proxy sellers appear misconfigured.Testing
pnpm --filter @antseed/cli run typecheckpassespnpm --filter @antseed/cli run buildpassesnetwork browse— no delegated sellers in top 5network browse— Venice.ai Proxy in results1f228613…dedf18c9, others show—network browse --servicesnetwork browse --jsonsellerAddressandisDelegatedSellerpresent on all peers; Venice hasisDelegatedSeller: truenetwork peer <venice-id>network peer <non-delegated-id>network peer <id> --jsonsellerAddressandisDelegatedSellerat top levelpeer.peerId, unchangedNo new unit tests added — the network commands currently have no unit test coverage (pre-existing).
Checklist
pnpm run buildpasses (@antseed/clitypecheck + build verified; full repo build fails on pre-existing native module issue unrelated to this change)pnpm run testpasses (CLI has no test suite; other packages pass)