Repository navigation
Fix precise signup validation feedback - #178
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and result
Signup validation collapsed short usernames, invalid characters, password failures, and malformed credentials into vague feedback. Duplicate usernames and suspended sign-ins could also surface in the wrong place or as generic server failures.
This change gives users precise, accessible field-level guidance while keeping the backend authoritative and the wire response bounded. Usernames are consistently trimmed and lowercased, duplicate names attach to the username field, suspension expiry is rendered truthfully, and in-flight submissions lock form state so stale responses cannot overwrite newer input.
Implementation
Verification
npm test -w @metaverse/shared -- --run src/rest.test.ts src/auth-failure.test.ts— 35 passednpm test -w frontend -- --run src/net/auth.test.ts— 12 passedNODE_OPTIONS='--localstorage-file=/tmp/hyprverse-auth-vitest-storage' npm test -w frontend -- --run src/ui/Landing.test.tsx— 15 passednpm run test:integration -w metaverse-backend -- --run test/integration/api.integration.test.ts— 34 passednpm run build— passednpm run size -w frontend— entry 100.2 KB gzipped, within 130 KB budget