fix(call): keep Leave pill, drop screenshot, gate share stage - #213
Merged
Merged
Conversation
Presentation layout now waits for a real local or remote MediaStream so Share no longer flashes a black stage. Screenshot capture is gone from the overflow menu and the client; the dedicated red Leave pill stays, with Leave kept as a secondary menu path.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In-call chrome no longer flashes a black presentation stage when you click Share, screenshot is gone, and the dedicated red Leave pill stays.
Changes
hasScreenon a real local or remote screen stream, not share intentWhy
Clicking Present switched the room to a black stage before a stream existed. Screenshot was a leftover menu action Raja asked to delete. Leave should stay as a visible pill, not only a menu item.
Testing
useScreenShare,ControlBar, full client suite + coverage floors)npm run typecheckChecklist