Conversation
Eliminates automatic binding of the local SSH directory into the development container for improved portability and to reduce potential security concerns. Retains all other configuration settings.
Ensures bench setup uses Python 3.11 for improved compatibility and consistency across environments.
There was a problem hiding this comment.
Pull request overview
This PR updates the Linux development environment configuration to improve Git repository management in VSCode and specify Python 3.11 for the Frappe bench initialization process.
- Adds VSCode settings for enhanced Git repository detection and submodule management
- Specifies Python 3.11 explicitly when initializing the Frappe bench
- Removes SSH mount configuration from the dev container setup
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| development/build.sh | Adds --python /usr/bin/python3.11 flag to bench initialization command to specify Python version |
| development/.vscode/settings.json | Adds Git configuration settings to enable automatic repository detection, submodule detection, and repository scanning in the apps directory |
| .devcontainer/devcontainer.json | Removes SSH mount configuration and adds a blank line at the beginning of the file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Luigi Azor <146014608+luigiazoreng@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Luigi Azor <146014608+luigiazoreng@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| else | ||
| PYTHON_BIN="python3" | ||
| fi | ||
| CMD_BENCH_SETUP="bench init --skip-redis-config-generation --python \"$PYTHON_BIN\" frappe-bench" |
There was a problem hiding this comment.
The quotes around the PYTHON_BIN variable will be interpreted literally by the shell. When the command is executed via 'eval', the escaped quotes will result in the path being passed as a quoted string to the bench init command, which may not work as intended. Consider removing the escaped quotes since the variable expansion should handle the path correctly without them.
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
|
@luigiazoreng I've opened a new pull request, #8, to work on those changes. Once the pull request is ready, I'll request review from you. |
This PR includes updates to the Linux development environment configuration: