Skip to content

🔒 Fix Hardcoded Email Password in appsettings.json #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AnyTng wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🔒 Fix Hardcoded Email Password in appsettings.json #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/RESTful API/appsettings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@

"EmailSettings": {
"From": "carexpress.suporte@gmail.com",
"Password": "kwjs rove xfka wanf",
"Password": "",

Copilot AI Apr 6, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting EmailSettings:Password to an empty string will cause EmailService authentication to fail at runtime unless a higher-precedence config source (e.g., EmailSettings__Password env var / user-secrets) is set. Consider adding configuration validation (fail fast with a clear error) so missing secrets don’t become a harder-to-debug SMTP auth error later.

Suggested change
"Password": "",

Copilot uses AI. Check for mistakes.
"SmtpServer": "smtp.gmail.com",
"Port": 465
Comment on lines 28 to 32

Copilot AI Apr 6, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although EmailSettings:Password is no longer hardcoded, appsettings.json still includes other hardcoded secrets (JWT secret, SQL connection string password, Stripe keys). Consider moving those to environment variables/user-secrets as well, and rotate any credentials that were previously committed because they remain in git history after this change.

Copilot uses AI. Check for mistakes.
}
Expand Down