⚡ Eliminate N+1 query in ServicoInterno

backend/.gitignore

@@ -0,0 +1,5 @@
+
+# Ignore build artifacts
+[Bb]in/
+[Oo]bj/
+BenchmarkDotNet.Artifacts/

backend/Benchmark/Benchmark.csproj

@@ -0,0 +1,21 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+  <PropertyGroup>
+    <OutputType>Exe</OutputType>
+    <TargetFramework>net9.0</TargetFramework>
+    <ImplicitUsings>enable</ImplicitUsings>
+    <Nullable>enable</Nullable>
+  </PropertyGroup>
+
+  <ItemGroup>
+    <PackageReference Include="BenchmarkDotNet" Version="0.15.8" />
+    <PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="9.0.4" />
+    <PackageReference Include="Microsoft.EntityFrameworkCore.Sqlite" Version="9.0.4" />
+    <PackageReference Include="Moq" Version="4.20.72" />
+  </ItemGroup>
+
+  <ItemGroup>
+    <ProjectReference Include="..\RESTful API\RESTful API.csproj" />
+  </ItemGroup>
+
+</Project>

backend/Benchmark/Program.cs

@@ -0,0 +1,121 @@
+using System;
+using System.Linq;
+using System.Threading.Tasks;
+using BenchmarkDotNet.Attributes;
+using BenchmarkDotNet.Running;
+using Microsoft.EntityFrameworkCore;
+using Microsoft.Extensions.Logging;
+using Microsoft.Extensions.Configuration;
+using Moq;
+using RESTful_API.Models;
+using RESTful_API.Service;
+using RESTful_API.Interface;
+using Microsoft.Data.Sqlite;
+using System.Data.Common;
+
+[MemoryDiagnoser]
+public class ServicoInternoBenchmark
+{
+    private PdsContext _context = null!;
+    private DbConnection _connection = null!;
+
+    [GlobalSetup]
+    public void Setup()
+    {
+        _connection = new SqliteConnection("Filename=:memory:");
+        _connection.Open();
+
+        var options = new DbContextOptionsBuilder<PdsContext>()
+            .UseSqlite(_connection)
+            .Options;
+
+        _context = new PdsContext(options);
+        _context.Database.EnsureCreated();
+
+        _context.Database.ExecuteSqlRaw("PRAGMA foreign_keys = OFF;");
+
+        // Seed data
+        var login = new Login { Idlogin = 1, Email = "test@test.com" };
+        _context.Logins.Add(login);
+
+        for (int i = 1; i <= 200; i++)
+        {
+            var cliente = new Cliente { Idcliente = i, NomeCliente = "Cliente " + i, LoginIdlogin = 1 };
+            _context.Clientes.Add(cliente);
+
+            var aluguer1 = new Aluguer {
+                Idaluguer = i * 2 - 1,
+                ClienteIdcliente = i,
+                EstadoAluguer = "Alugado",
+                DataEntregaPrevista = DateTime.Now.AddDays(-1),
+                VeiculoIdveiculo = 1,
+            };
+
+            _context.Aluguers.Add(aluguer1);
+        }
+
+        var loginNav = new Login { Idlogin = 2, Email = "test2@test.com" };
+        _context.Logins.Add(loginNav);
+        _context.SaveChanges();
+
+        _context.ChangeTracker.Clear();
+    }
+
+    [IterationSetup]
+    public void IterationSetup()
+    {
+        _context.ChangeTracker.Clear();
+    }
+
+    [GlobalCleanup]
+    public void Cleanup()
+    {
+        _connection.Dispose();
+        _context.Dispose();
+    }
+
+    [Benchmark(Baseline = true)]
+    public async Task NPlusOne()
+    {
+        var aluguers = await _context.Aluguers
+            .Include(a=>a.ClienteIdclienteNavigation)
+            .Where(a=>a.EstadoAluguer=="Aguarda Levantamento" || a.EstadoAluguer == "Alugado")
+            .ToListAsync();
+
+        foreach (var aluguer in aluguers)
+        {
+            if (aluguer.DataEntregaPrevista < DateTime.Now && aluguer.EstadoAluguer == "Alugado")
+            {
+                var cliente = await _context.Clientes
+                    .Include(c => c.LoginIdloginNavigation)
+                    .FirstOrDefaultAsync(c => c.Idcliente == aluguer.ClienteIdcliente);
+            }
+        }
+    }
+
+    [Benchmark]
+    public async Task Optimized()
+    {
+        var aluguers = await _context.Aluguers
+            .Include(a=>a.ClienteIdclienteNavigation)
+            .ThenInclude(c => c.LoginIdloginNavigation)
+            .Where(a=>a.EstadoAluguer=="Aguarda Levantamento" || a.EstadoAluguer == "Alugado")
+            .ToListAsync();
+
+        foreach (var aluguer in aluguers)
+        {
+            if (aluguer.DataEntregaPrevista < DateTime.Now && aluguer.EstadoAluguer == "Alugado")
+            {
+                var cliente = aluguer.ClienteIdclienteNavigation;
+            }
+        }
+    }
+}
+
+public class Program
+{
+    public static void Main(string[] args)
+    {
+        var summary = BenchmarkRunner.Run<ServicoInternoBenchmark>();
+    }
+}

backend/RESTful API/Service/ServicoInterno.cs

@@ -36,18 +36,18 @@ public async Task Executar()
         {
             // Lógica da tarefa interna
             var aluguers = await _context.Aluguers
-                .Include(a=>a.ClienteIdclienteNavigation)
-                .Where(a=>a.EstadoAluguer=="Aguarda Levantamento" && a.EstadoAluguer == "Alugado")
+                .Include(a => a.ClienteIdclienteNavigation)
+                .ThenInclude(c => c.LoginIdloginNavigation)
+                .Where(a => a.EstadoAluguer == "Aguarda Levantamento" || a.EstadoAluguer == "Alugado")
                 .ToListAsync();
 
 
             foreach (var aluguer in aluguers)
             {
                 if (aluguer.DataEntregaPrevista < DateTime.Now && aluguer.EstadoAluguer == "Alugado")
                 {
-                    var cliente = await _context.Clientes
-                        .Include(c => c.LoginIdloginNavigation)
-                        .FirstOrDefaultAsync(c => c.Idcliente == aluguer.ClienteIdcliente); if (cliente != null )
+                    var cliente = aluguer.ClienteIdclienteNavigation;
+                    if (cliente != null)
                     {
                         var email = cliente.LoginIdloginNavigation.Email;
                         var assunto = "Notificação de Devolução do Veiculo";
@@ -69,9 +69,7 @@ public async Task Executar()
 
                 if (aluguer.DataLevantamento < DateTime.Now && aluguer.EstadoAluguer == "Aguarda Levantamento")
                 {
-                    var cliente = await _context.Clientes
-                        .Include(c => c.LoginIdloginNavigation)
-                        .FirstOrDefaultAsync(c => c.Idcliente == aluguer.ClienteIdcliente); 
+                    var cliente = aluguer.ClienteIdclienteNavigation;
 
                     if (cliente != null)
                     {