Repository navigation
Mac launcher: VK's twelve languages, mirrored screens for Arabic and Urdu - #36
Merged
Merged
Conversation
…or Arabic and Urdu German, Spanish, French, Portuguese, Indonesian, Russian, Japanese, Hindi, Bengali, Bhojpuri, Arabic and Urdu, translated by VK for the Windows/Linux launcher. Each file holds only the keys whose English reads the same in both launchers' en.json, so no translation of another English text is reused. The rest shows in English. The language picker lists them from the files, as before. scripts/import-port-translations.py carries them over again when the Port's files change. Arabic and Urdu lay the screens out right to left, and the arrows follow what is drawn. LanguageCheckTests check the partial files: listed by name, English placeholders, English where a text is missing, and the mirrored arrows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Launcher parity with AnyLauncher Port: the Port's twelve extra languages on the Mac.
tools/macos/launcher/l10n/{ar,bho,bn,de,es,fr,hi,id,ja,pt,ru,ur}.json, translated by VK for the Windows/Linux launcher. Each file holds only the keys whose English text is the same in both launchers'en.json(861 of 1842), checked key by key. A key whose English differs (PC against Mac) is left out and shows in English.scripts/import-port-translations.py <Port checkout>carries them over again when the Port's files change. It keeps a text translated here for a key only the Mac has.layoutDirection), and ← and → follow what is drawn, so the row of games and the panels move as they look.en.json, and a missing text shows in English. A test for the mirrored arrows.l10n/TRANSLATING.mdcredit VK as the Port does.Checked:
swift build,swift test --filter "LanguageCheckTests|LanguageFilesTests"(all pass), and offscreen renders of the home screen in Arabic (--render-preview).