Skip to content

fix: handle pinned Ape plugins in build generation - #296

Merged
fubuloubu merged 2 commits into
ApeWorX:mainfrom
sanjaysudagani:codex/fix-pinned-plugin-build-generate
Mar 4, 2026
Merged

fix: handle pinned Ape plugins in build generation#296
fubuloubu merged 2 commits into
ApeWorX:mainfrom
sanjaysudagani:codex/fix-pinned-plugin-build-generate

Conversation

@sanjaysudagani

@sanjaysudagani sanjaysudagani commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

What I did

Updated generated Dockerfiles so Silverback does not call ape plugins install -U . when project Ape plugins are version-pinned.

fixes: #220

How I did it

  • inspected Ape project config for pinned plugin versions in ape-config.yaml and pyproject.toml
  • generated ape plugins install . for pinned-plugin projects
  • preserved ape plugins install -U . for unpinned projects
  • added regression tests for both supported config formats
  • documented the pinned-plugin behavior in the deployment guide

How to verify it

. .venv/bin/activate && pytest tests/test_utils.py -q
. .venv/bin/activate && ruff check silverback/_build_utils.py tests/test_utils.py
. .venv/bin/activate && ruff format --check silverback/_build_utils.py tests/test_utils.py

Then review docs/userguides/deploying.md for the pinned-plugin deployment note.

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@fubuloubu fubuloubu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great fix!

I also think that an additional fix could be added upstream to ape plugins install so that it would function correctly w/ pinned dependencies with or without --upgrade

@fubuloubu
fubuloubu enabled auto-merge (squash) March 4, 2026 04:03
@fubuloubu
fubuloubu disabled auto-merge March 4, 2026 04:07
@fubuloubu
fubuloubu merged commit 1ec156d into ApeWorX:main Mar 4, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

silverback build --generate doesn't work with pinned plugins in ape-config.yaml

2 participants