Pass block hash through parse_block_identifier instead of resolving it#3841
Open
genisis0x wants to merge 1 commit into
Open
Pass block hash through parse_block_identifier instead of resolving it#3841genisis0x wants to merge 1 commit into
parse_block_identifier instead of resolving it#3841genisis0x wants to merge 1 commit into
Conversation
`Contract.call` and the async variant routed user-supplied block hashes through `parse_block_identifier` / `async_parse_block_identifier`, which called `eth.get_block(...)` purely to read back `block["number"]` and then forwarded that number to `eth_call`. The execution-apis spec lists block hashes as a valid default-block parameter, and the major clients (geth, reth, erigon, nethermind) accept them on `eth_call` and `eth_estimateGas`, so the lookup was a redundant round-trip. Forward the hash (normalized via `to_hex_if_bytes`) directly. Existing parse-block-identifier tests are updated to assert passthrough. If a node does not support block hashes for these methods, its native RPC error propagates to the caller unchanged. Closes ApeWorX#3646
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`Contract.call` and the async variant routed user-supplied block hashes through `parse_block_identifier` / `async_parse_block_identifier`, which called `eth.get_block(...)` purely to read `block["number"]` and then forwarded the number to `eth_call`. The execution-apis spec lists block hashes as a valid default-block parameter, and the major clients (geth, reth, erigon, nethermind) accept them on `eth_call` / `eth_estimateGas`, so the lookup was a redundant round-trip.
Forward the hash (normalized via `to_hex_if_bytes`) directly. If a node does not support block hashes for these methods, its native RPC error propagates to the caller unchanged.
Closes #3646
Test plan