Emit compact JSON for outgoing JSON-RPC payloads#3842
Open
genisis0x wants to merge 1 commit into
Open
Conversation
FriendlyJsonSerde.json_encode left json.dumps at its default separators,
which pad every entry with ", " and ": ". Every payload that web3.py
sends is consumed by another machine, so the spacing is pure overhead.
Pass `separators=(",", ":")` to drop ~2 bytes per dict/list entry. This
adds up across large payloads such as `eth_getLogs` results, batched
JSON-RPC requests, and verbose websocket logs without changing
semantics.
Closes ApeWorX#3496 (compact-encoding portion)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`FriendlyJsonSerde.json_encode` left `json.dumps` at its default separators, which pad every entry with `", "` and `": "`. Every payload web3.py sends is consumed by another machine, so the spacing is pure overhead.
Pass `separators=(",", ":")` to drop ~2 bytes per dict/list entry. This adds up across large payloads (`eth_getLogs` results, batched JSON-RPC requests, verbose websocket logs) without changing semantics.
Closes #3496 (compact-encoding portion of the issue; other suggestions there can be addressed in follow-up PRs).
Test plan