Repository navigation
LLMClient.stream docstring references last_response, which the Protocol does not declare #3
Description
Activity
- added a commit that references this issue
on Aug 31, 2026 Settled on
mainby 63dba6f (not auto-linked — literal\n\nbefore theRefstrailer).Of the two options this issue put up, the second was taken: the reference is dropped and the assembler owns the terminal response.
LLMClient.streamnow documents (agent_core/llm.py:99):Terminal metadata is carried by late deltas; the consuming runtime is responsible for assembling those deltas into its final response.
No
last_responsewas added to the Protocol. The rationale is the one the issue itself noted:StreamDeltaalready carriesusage/finish_reason/providerprecisely so an assembler can build the terminal response, so requiring hosts to also implement a statefullast_response()would duplicate that contract and force every host to keep per-stream state the Protocol cannot enforce. A host now implements exactly what it can implement.This was flagged as needing to be settled before the LLM runtime slice (migration step 3) lands on top of it — it is settled, and that slice should assemble from deltas.
Downstream:
miroharness/core/llm.pystill carries the old wording. Tracking that backport separately.Correction to the "Downstream" note above.
That note is accurate for MiroHarness
main, which still carries the standalone 790-line copy — but it is already stale for the integration branch. Onrefactor/agent-core,miroharness/core/loop_types.pyis a 75-line compatibility facade that re-exportsagent_core.loop_types(done by1bedcc52 refactor: consume shared runtime contracts), and that branch pins:apodex-agent-core @ git+ssh://git@github.com/ApodexAI/AgentCore.git@a9b5272dgit merge-base --is-ancestor 63dba6f a9b5272confirms the pin already contains this fix.So no backport is needed. The downstream copy is not being patched in parallel; it is being deleted by the extraction. MiroHarness
mainkeeps the old code only untilrefactor/agent-corelands, and this fix arrives there through the pin rather than through a second edit.The only product-specific symbol that stays behind in the facade is
wall_deadline_remaining_s, which bindsmiroharness.core.execution_contextand is registered as an allowed delta inscripts/contract/manifest.py.
agent_core/llm.py:87documents how to retrieve the terminal response:But
LLMClientdeclares onlychatandstream.last_responseappears nowhere else in the package — a grep of ApodexHarness finds no definition either, only unrelated local variables.Consequence: a host implementing exactly the published Protocol has no such method, so a consumer typed against
LLMClienteither fails strict type-check or raisesAttributeErrorat runtime. This is the half of the streaming contract a host currently has to guess at, even thoughStreamDeltawas deliberately givenusage/finish_reason/providerso an assembler can build that response.Decision needed: either declare
last_response() -> LLMResponse | Noneon the Protocol, or drop the reference and document the assembler as the owner of the terminal response. Blocks nothing, but should be settled before the LLM runtime slice (migration step 3) lands on top of it.Provenance: pre-existing in
ApodexHarness/miroharness/core/llm.py:92, ported verbatim by #1 — not introduced by the refactor. ApodexHarness carries the same wording; settle the contract once, then change both.