adds lint checks to web shared pkg by redreceipt · Pull Request #263 · ApollosProject/apollos-embeds

redreceipt · 2025-12-11T13:48:40Z

No description provided.

Copilot

Pull request overview

This pull request adds ESLint configuration and enforcement to the web-shared package, bringing it in line with consistent code styling standards across the project. The changes include adding a linting script, configuring ESLint rules, and applying automated formatting fixes throughout the codebase.

Key Changes:

Added ESLint configuration file (.eslintrc.js) with rules for import ordering, comment formatting, and code style
Added lint script to package.json for the web-shared package
Updated GitHub Actions workflow to include linting checks for the web-shared package alongside web-embeds
Applied automated formatting fixes across 100+ files including import statement reorganization, comment spacing corrections, and code formatting improvements

Reviewed changes

Copilot reviewed 166 out of 168 changed files in this pull request and generated 28 comments.

Show a summary per file

File	Description
`.github/workflows/lint.yml`	Extended CI workflow to run lint checks on web-shared package; updated to use latest GitHub Actions versions
`packages/web-shared/.eslintrc.js`	New ESLint configuration defining import ordering, comment formatting, and style rules
`packages/web-shared/package.json`	Added lint script to enable ESLint checks
`yarn.lock`	Updated dependency entries for string-width, strip-ansi, and wrap-ansi packages
`packages/web-shared/*/.js`	Applied automated formatting fixes including import reordering, comment spacing, quote consistency, and line break adjustments across all JavaScript files

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-11T14:27:13Z

-import SearchStyles from '../Searchbar/Search.styles';
-
+import { useCurrentChurch } from '../../hooks';
+import { Box, Avatar } from '../../ui-kit';


Unused import Avatar.

Suggested change

import { Box, Avatar } from '../../ui-kit';

import { Box } from '../../ui-kit';

Copilot · 2025-12-11T14:27:13Z

+import { useCurrentChurch } from '../../hooks';
+import { Box, Avatar } from '../../ui-kit';
 import ProfileButton from '../Profile/ProfileButton';
+import SearchStyles from '../Searchbar/Search.styles';


Unused import SearchStyles.

Suggested change

import SearchStyles from '../Searchbar/Search.styles';

Copilot · 2025-12-11T14:27:13Z

-import { withTheme } from 'styled-components';
-import styled, { css } from 'styled-components';
 import { themeGet } from '@styled-system/theme-get';
+import styled, { withTheme, css } from 'styled-components';


Unused import css.

Suggested change

import styled, { withTheme, css } from 'styled-components';

import styled, { withTheme } from 'styled-components';

Copilot · 2025-12-11T14:27:14Z

-  H6,
-  SmallBodyText,
-} from '../../../ui-kit';
+import { Avatar, Card, Box, Button, Input, H2, H5, H6, SmallBodyText } from '../../../ui-kit';


Unused imports H2, H5.

Suggested change

import { Avatar, Card, Box, Button, Input, H2, H5, H6, SmallBodyText } from '../../../ui-kit';

import { Avatar, Card, Box, Button, Input, H6, SmallBodyText } from '../../../ui-kit';

Copilot · 2025-12-11T14:27:14Z

-import { getURLFromType } from '../utils';
-import { ContentCard, Box, H3, systemPropTypes, Button } from '../ui-kit';
 import { useNavigation } from '../providers/NavigationProvider';
+import { ContentCard, Box, H3, systemPropTypes, Button } from '../ui-kit';


Unused import H3.

Suggested change

import { ContentCard, Box, H3, systemPropTypes, Button } from '../ui-kit';

import { ContentCard, Box, systemPropTypes, Button } from '../ui-kit';

Copilot · 2025-12-11T14:27:20Z

+
 import { Check } from '@phosphor-icons/react';
-import { unit } from '../../utils';
+import isNil from 'lodash/isNil';


Unused import isNil.

Copilot · 2025-12-11T14:27:20Z

-import { Title, Image, BottomSlot, CompleteIndicator, Ellipsis } from './MediaItem.styles';
 import LiveChip from './LiveChip';
-import { useLivestreamStatus } from '../../hooks';
+import { Title, Image, BottomSlot, CompleteIndicator, Ellipsis } from './MediaItem.styles';


Unused imports Image, Title.

Copilot · 2025-12-11T14:27:21Z

-import { useLivestreamStatus } from '../../hooks';
+import { Title, Image, BottomSlot, CompleteIndicator, Ellipsis } from './MediaItem.styles';
+import { useVideoMediaProgress, useLivestreamStatus } from '../../hooks';
+import { BodyText, SmallBodyText, Box, H4, systemPropTypes, ProgressBar } from '../../ui-kit';


Unused imports BodyText, SmallBodyText.

Copilot · 2025-12-11T14:27:21Z

-import { withTheme } from 'styled-components';
-import styled, { css } from 'styled-components';
 import { themeGet } from '@styled-system/theme-get';
+import styled, { withTheme, css } from 'styled-components';


Unused import css.

Copilot · 2025-12-11T14:27:21Z

-import { withTheme } from 'styled-components';
-import styled, { css } from 'styled-components';
 import { themeGet } from '@styled-system/theme-get';
+import styled, { withTheme, css } from 'styled-components';


Unused import css.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

redreceipt · 2025-12-11T14:46:22Z

@vitlelis i'll address unused import warnings in a follow up

dsilva609

Hmm this looks like the old eslint config (<8.57) format. Can we update this to be eslint 9 compatible as outlined here? https://eslint.org/docs/latest/use/migrate-to-9.0.0

redreceipt · 2025-12-11T15:08:46Z

Hmm this looks like the old eslint config (<8.57) format. Can we update this to be eslint 9 compatible as outlined here? https://eslint.org/docs/latest/use/migrate-to-9.0.0

can we do that in a follow up? the purpose of this PR is simply to introduce lint checks to the majority of the code. I've already found and fixed one bug.

dsilva609 · 2025-12-11T15:11:31Z

Hmm this looks like the old eslint config (<8.57) format. Can we update this to be eslint 9 compatible as outlined here? https://eslint.org/docs/latest/use/migrate-to-9.0.0

can we do that in a follow up? the purpose of this PR is simply to introduce lint checks to the majority of the code. I've already found and fixed one bug.

Actually, since this is in maintenance mode, we can probably leave it as is 👍

nlewis84

I'm good with this since we are pushing everyone to get off this package.

redreceipt added 6 commits December 11, 2025 08:48

adds lint checks to web shared pkg

0082b72

🤘

e6a15cf

🤘

ea5cf36

merge

938b618

🤘

e2b3e5b

🤘

6a1e085

redreceipt marked this pull request as ready for review December 11, 2025 14:21

redreceipt requested a review from Copilot December 11, 2025 14:22

Copilot started reviewing on behalf of redreceipt December 11, 2025 14:22 View session

Copilot AI reviewed Dec 11, 2025

View reviewed changes

Update packages/web-shared/components/AppHeader/AppHeader.js

922f58d

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

redreceipt force-pushed the lint-web-shared branch from 8888d47 to 922f58d Compare December 11, 2025 14:44

redreceipt enabled auto-merge December 11, 2025 14:45

redreceipt requested a review from vitlelis December 11, 2025 14:45

redreceipt requested review from dsilva609 and nlewis84 December 11, 2025 14:56

dsilva609 suggested changes Dec 11, 2025

View reviewed changes

redreceipt requested a review from dsilva609 December 11, 2025 15:26

dsilva609 approved these changes Dec 11, 2025

View reviewed changes

redreceipt added this pull request to the merge queue Dec 11, 2025

Merged via the queue into main with commit 3c9a940 Dec 11, 2025
3 checks passed

redreceipt deleted the lint-web-shared branch December 11, 2025 15:33

nlewis84 approved these changes Dec 11, 2025

View reviewed changes

	import { Box, Avatar } from '../../ui-kit';
	import { Box } from '../../ui-kit';

	import styled, { withTheme, css } from 'styled-components';
	import styled, { withTheme } from 'styled-components';

	import { Avatar, Card, Box, Button, Input, H2, H5, H6, SmallBodyText } from '../../../ui-kit';
	import { Avatar, Card, Box, Button, Input, H6, SmallBodyText } from '../../../ui-kit';

	import { ContentCard, Box, H3, systemPropTypes, Button } from '../ui-kit';
	import { ContentCard, Box, systemPropTypes, Button } from '../ui-kit';

Conversation

redreceipt commented Dec 11, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

redreceipt commented Dec 11, 2025

Uh oh!

dsilva609 left a comment

Choose a reason for hiding this comment

Uh oh!

redreceipt commented Dec 11, 2025

Uh oh!

dsilva609 commented Dec 11, 2025

Uh oh!

Uh oh!

nlewis84 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants