Support AudioMedia in legacy embeds#267
Conversation
|
@nlewis84 when i tested the first time, i simulated the data wrong 😢 i forgot we have separate audio media fields. this fixes that |
| const hasSource = (video) => video.sources?.some((source) => source?.uri); | ||
| const mediaItems = props.parentNode?.videos?.length | ||
| ? props.parentNode.videos | ||
| : props.parentNode?.audios || []; |
There was a problem hiding this comment.
I think I'm okay with this but just want to call out that this is a variance from how we do this on mobile.
On mobile, the video player only plays the video if one exists. There is now a separate audio player that exists below the cover image that plays audio if there is audio.
If there is both audio and video available, both players are visible.
I don't think we have an audio player on web right now?
There was a problem hiding this comment.
@conrad-vanl is the legacy embed repo. I added audio support in a previous PR
|
@redreceipt Is the CS looped in that client that is reporting this should get moved off this old infrastructure asap? |
3 participants
Summary
Testing
Closes APO-7576
Closes APO-7468