[codex] Fix leaderboard posting#322
Merged
Merged
Conversation
23b3ee9 to
2fce29d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the weekly leaderboard worker path so it can post successfully and run at the intended 4pm Eastern wall-clock time.
Root cause
The completed-project contributor query declared
$project_idasString!, but Linear'sproject.id.eqfilter expects anID. That caused a GraphQL validation error before the worker reached the Slack post.The leaderboard schedule also used
friday.at("20:00")without a timezone, unlike the other wall-clock Slack jobs. On UTC workers that resolved to 20:00 UTC instead of the intended Eastern-time schedule.Changes
ID!.post_leaderboardat16:00inAmerica/New_York.post_inactive_engineersin the debug-job test so it stays focused on debug job orchestration.Validation
.venv-ci/bin/python -m unittest tests.test_jobs tests.test_linear_projects tests.test_leaderboard.venv-ci/bin/ruff check jobs.py tests/test_jobs.py linear/projects.py tests/test_linear_projects.py.venv-ci/bin/ruff format --check jobs.py tests/test_jobs.py linear/projects.py tests/test_linear_projects.pyTZ=UTCthat16:00 America/New_Yorkresolves to20:00 UTC/16:00 Eastern.