Skip to content

chore: upload menu hint text error#251

Open
asjqkkkk wants to merge 1 commit intoAppFlowy-IO:mainfrom
asjqkkkk:fix/hint/issue
Open

chore: upload menu hint text error#251
asjqkkkk wants to merge 1 commit intoAppFlowy-IO:mainfrom
asjqkkkk:fix/hint/issue

Conversation

@asjqkkkk
Copy link

@asjqkkkk asjqkkkk commented Feb 6, 2026

Before:
image

After:
image

Description


Checklist

General

  • I've included relevant documentation or comments for the changes introduced.
  • I've tested the changes in multiple environments (e.g., different browsers, operating systems).

Testing

  • I've added or updated tests to validate the changes introduced for AppFlowy Web.

Feature-Specific

  • For feature additions, I've added a preview (video, screenshot, or demo) in the "Feature Preview" section.
  • I've verified that this feature integrates seamlessly with existing functionality.

Summary by Sourcery

Bug Fixes:

  • Correct the hint text in the file upload menu to reference the appropriate file upload message suffix.

@sourcery-ai
Copy link

sourcery-ai bot commented Feb 6, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the upload menu hint text for the file block popover to use a new i18n key for the suffix portion of the hint.

File-Level Changes

Change Details Files
Adjust the file upload hint text suffix in the file block popover to use a dedicated translation key.
  • Change the placeholder hint suffix from using the photo gallery browser layout translation key to a new file upload hint suffix translation key
  • Keep the overall placeholder structure and styling the same while only swapping the inner i18n key
src/components/editor/components/block-popover/FileBlockPopoverContent.tsx

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Since the hint text is now composed from two translation keys, please double-check that this concatenation makes sense in all supported locales (word order, spacing) or consider using a single i18n key for the full sentence to avoid localization issues.
  • Ensure that the new document.plugins.file.fileUploadHintSuffix key is present and correctly defined in all locale files so the UI doesn’t show missing-key fallbacks in some languages.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Since the hint text is now composed from two translation keys, please double-check that this concatenation makes sense in all supported locales (word order, spacing) or consider using a single i18n key for the full sentence to avoid localization issues.
- Ensure that the new `document.plugins.file.fileUploadHintSuffix` key is present and correctly defined in all locale files so the UI doesn’t show missing-key fallbacks in some languages.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant